Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-17657 Add internal timer to initiate logout #10382

Merged
merged 1 commit into from Sep 26, 2017

Conversation

miguelvazq
Copy link

@miguelvazq miguelvazq commented Aug 31, 2017

Will use configuration expiration time and detect if user is inactive/active and display idle popup box according to configured time.

Signed-off-by: Miguel Vazquez miguel.vazquez@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@hpcc-jirabot
Copy link

@miguelvazq
Copy link
Author

@GordonSmith Please take initial look at this.

@GordonSmith
Copy link
Member

@miguelvazq My suggested tweaks: #10409

@miguelvazq
Copy link
Author

As per your comments / tweaks also added dynamic cookie timeout (defaults to 120min in configuration)

@miguelvazq
Copy link
Author

Will add translations in other ticket

@richardkchapman
Copy link
Member

@GordonSmith Please re-review

@@ -165,6 +166,7 @@ define({root:
Downloads: "Downloads",
DownloadToCSV: "Download to CSV",
DropZone: "Drop Zone",
DueToInctivity: "Due to inactivity, you will be logged out of your ECL Watch session in 3 minutes. This will close any sessions open in other tabs for this envrionment. Click on \'Continue Working\' to extend your session or click on \'Log Out\' to exit.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: environment
Suggested wording: Due to inactivity, you will be logged out of your ECL Watch session in 3 minutes. This will close all open sessions for this environment. Click on \'Continue Working\' to extend your session or click on \'Log Out\' to exit."

(You can make this change when you do the translations?)

entities, Toaster) {

var initUi = function () {
var IDLE_TIMEOUT = cookie("ESPSessionTimeoutSeconds") * 1000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a default value in case the cookie is not present?

var ESPSessionTimeoutSeconds = cookie("ESPSessionTimeoutSeconds") || 180;

@GordonSmith
Copy link
Member

One comment re the cookie.

Will use configuration expiration time and detect if user is inactive/active and display idle popup box according to configured time.

Signed-off-by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
@miguelvazq
Copy link
Author

@GordonSmith Updated.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
Sha: 7171a59
Build: success
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 75 41.664 seconds

Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 92 92 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 744 744 0
test (thor) 639 639 0
test (roxie) 772 772 0

HPCC Stop: OK
HPCC Uninstall: OK

@GordonSmith
Copy link
Member

Looks good.

@miguelvazq
Copy link
Author

@richardkchapman Ready to merge.

@richardkchapman richardkchapman merged commit c7a3d43 into hpcc-systems:master Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants