New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-17657 Add internal timer to initiate logout #10382
Conversation
https://track.hpccsystems.com/browse/HPCC-17657 |
@GordonSmith Please take initial look at this. |
@miguelvazq My suggested tweaks: #10409 |
ce45a5a
to
a0ae99c
Compare
As per your comments / tweaks also added dynamic cookie timeout (defaults to 120min in configuration) |
Will add translations in other ticket |
@GordonSmith Please re-review |
esp/src/eclwatch/nls/hpcc.js
Outdated
@@ -165,6 +166,7 @@ define({root: | |||
Downloads: "Downloads", | |||
DownloadToCSV: "Download to CSV", | |||
DropZone: "Drop Zone", | |||
DueToInctivity: "Due to inactivity, you will be logged out of your ECL Watch session in 3 minutes. This will close any sessions open in other tabs for this envrionment. Click on \'Continue Working\' to extend your session or click on \'Log Out\' to exit.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: environment
Suggested wording: Due to inactivity, you will be logged out of your ECL Watch session in 3 minutes. This will close all open sessions for this environment. Click on \'Continue Working\' to extend your session or click on \'Log Out\' to exit."
(You can make this change when you do the translations?)
esp/src/eclwatch/stub.js
Outdated
entities, Toaster) { | ||
|
||
var initUi = function () { | ||
var IDLE_TIMEOUT = cookie("ESPSessionTimeoutSeconds") * 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have a default value in case the cookie is not present?
var ESPSessionTimeoutSeconds = cookie("ESPSessionTimeoutSeconds") || 180;
One comment re the cookie. |
Will use configuration expiration time and detect if user is inactive/active and display idle popup box according to configured time. Signed-off-by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
a0ae99c
to
7171a59
Compare
@GordonSmith Updated. |
Automated Smoketest: ✅
Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm Unit tests result:
Regression test result:
HPCC Stop: OK |
Looks good. |
@richardkchapman Ready to merge. |
Will use configuration expiration time and detect if user is inactive/active and display idle popup box according to configured time.
Signed-off-by: Miguel Vazquez miguel.vazquez@lexisnexis.com
Type of change:
Checklist:
Testing: