Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-18551 Copy WUID to Clipboard #10524

Merged

Conversation

Projects
None yet
4 participants
@GordonSmith
Copy link
Member

commented Oct 18, 2017

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@GordonSmith GordonSmith force-pushed the GordonSmith:HPCC-18551-CopyToClipboard branch 2 times, most recently from 832f224 to d630948 Oct 18, 2017

@GordonSmith

This comment has been minimized.

Copy link
Member Author

commented Oct 18, 2017

@miguelvazq Please review (once #10492 is pulled and this is rebased)

@GordonSmith GordonSmith force-pushed the GordonSmith:HPCC-18551-CopyToClipboard branch from d630948 to bd74bc8 Oct 19, 2017

@GordonSmith GordonSmith force-pushed the GordonSmith:HPCC-18551-CopyToClipboard branch from bd74bc8 to f145b81 Nov 15, 2017

@GordonSmith GordonSmith changed the title Hpcc 18551 copy to clipboard HPCC-18551 Copy WUID to Clipboard Nov 15, 2017

@GordonSmith

This comment has been minimized.

Copy link
Member Author

commented Nov 15, 2017

@miguelvazq this is ready for review.

@@ -1541,3 +1541,11 @@ margin-left:-20px;
margin: 0px;
font:0.75em;
}

button.clippy img {
margin:0px;

This comment has been minimized.

Copy link
@miguelvazq

miguelvazq Nov 16, 2017

Member

You can just do margin: 2px, 0, 0 here

HPCC-18551 Copy WUID to Clipboard
Signed-off-by: Gordon Smith <gordonjsmith@gmail.com>

@GordonSmith GordonSmith force-pushed the GordonSmith:HPCC-18551-CopyToClipboard branch from f145b81 to 54758a1 Nov 20, 2017

@GordonSmith

This comment has been minimized.

Copy link
Member Author

commented Nov 20, 2017

@miguelvazq change made as requested.

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Nov 20, 2017

Automated Smoketest:
Sha: 54758a1
Empty table
Build: success
Build: success
ECL Watch: Rebuilding Site
Empty table
Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 117 117 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 745 745 0
test (thor) 640 640 0
test (roxie) 773 773 0

HPCC Stop: OK
HPCC Uninstall: OK

@miguelvazq

This comment has been minimized.

Copy link
Member

commented Nov 20, 2017

Looks good.

@richardkchapman richardkchapman merged commit d0c5769 into hpcc-systems:master Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.