New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-18222 DESDL refresh issue when overwriting #10555
HPCC-18222 DESDL refresh issue when overwriting #10555
Conversation
https://track.hpccsystems.com/browse/HPCC-18222 |
@@ -48,9 +48,7 @@ define([ | |||
idProperty: "__hpcc_id", | |||
|
|||
init: function (params) { | |||
if (this.inherited(arguments)) | |||
return; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Delay loader will spot and call "refresh" with the new params as needed, so do not remove the call to the base class, instead change:
refresh: function () {
this.refreshGrid();
},
to:
refresh: function (params) {
this._params = params;
this.refreshGrid();
},
(You may need to also call the refreshState in there as well)
cf4bd54
to
697c772
Compare
@GordonSmith Modified. |
this._refreshActionState(); | ||
}, | ||
|
||
refresh: function () { | ||
refresh: function (params) { | ||
this._params = params; | ||
this.refreshGrid(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miguelvazq You may want to move the call to this._refreshActionState();
to inside the refresh function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GordonSmith Changed. Is this call required even if no event calls are being made on this particular grid? Tested and works as expected.
Whenever a navigates to a binding performs an action and then leaves and tries to perform another action the data from previous selection is still active. Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
697c772
to
2547119
Compare
Automated Smoketest: ✅
Install hpccsystems-platform-community_6.4.4-rc1.el7.x86_64.rpm Unit tests result:
Regression test result:
HPCC Stop: OK |
@richardkchapman Tested and performing as expected. Had a minor question, OK to merge once approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@richardkchapman Ready to merge. |
Whenever a navigates to a binding performs an action and then leaves and tries to perform another action the data from previous selection is still active.
Signed-off by: Miguel Vazquez miguel.vazquez@lexisnexis.com
Type of change:
Checklist:
Testing: