HPCC-18770 Fix crash in stand alone hthor program when using daliserver=... and -xml

[ghalliday]

Ensure standalone hthor output goes to stdout when the -xml option is used.

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Testing:

[hpcc-jirabot]

https://track.hpccsystems.com/browse/HPCC-18770
Jira updated

[ghalliday]

@richardkchapman please review

[richardkchapman]

It should really be going to stdout any time wuid is not specified. Seems no harder to fix that properly than to do this partial and incorrect fix...

[richardkchapman]

@ghalliday Back to you

[ghalliday]

@richardkchapman eclagent stand alone queries do not currently support wuid=xxx as well. So should it be that if it is a stand alone program then output always goes to stdout?

[ghalliday]

@richardkchapman pushed new commit.

[HPCCSmoketest]

Automated Smoketest: ❌
Sha: 40426c4
Build: success
Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout
unittest	116	116	0	0	0
wutoolTest(Dali)	19	19	0	0	0
wutoolTest(Cassandra)	19	19	0	0	0

Regression test result:

phase	total	pass	fail
setup (hthor)	11	11	0
setup (thor)	11	11	0
setup (roxie)	11	11	0
test (hthor)	727	727	0
test (thor)	640	638	2
test (roxie)	755	755	0

Errors:

• test
  • thor
    • 558. steplimit2 (multiPart=false), 559. steplimit2 (multiPart=true),

HPCC Stop: OK
HPCC Uninstall: OK