Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-18915 Unittests generates segmentation fault when load libraries. #10747

Merged

Conversation

AttilaVamos
Copy link
Contributor

@AttilaVamos AttilaVamos commented Dec 18, 2017

Add pointer check before dereferencing.

Signed-off-by: Attila Vamos attila.vamos@gmail.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

Tested manually.

Add pointer check before dereferencing.

Signed-off-by: Attila Vamos <attila.vamos@gmail.com>
@hpcc-jirabot
Copy link

@AttilaVamos AttilaVamos changed the title HPCC-18915 Unittests generate segmentation fault when load libraries. HPCC-18915 Unittests generates segmentation fault when load libraries. Dec 18, 2017
@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
Sha: c03b1a4
Build: success
Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 92 92 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 734 734 0
test (thor) 647 647 0
test (roxie) 761 761 0

HPCC Stop: OK
HPCC Uninstall: OK

@AttilaVamos
Copy link
Contributor Author

@richardkchapman please review and merge.

@richardkchapman richardkchapman merged commit 38da3a9 into hpcc-systems:master Dec 19, 2017
@ghalliday
Copy link
Member

checklist needs updating

@AttilaVamos
Copy link
Contributor Author

Checklist updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants