Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-18993 Remove incorrect comments regarding deprecated method. #10808

Merged
merged 1 commit into from Jan 25, 2018
Merged

HPCC-18993 Remove incorrect comments regarding deprecated method. #10808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion rtl/eclrtl/rtldynfield.cpp
View file
Open in desktop
Expand Up @@ -1670,7 +1670,7 @@ class CKeyTranslator : public CInterfaceOf<IKeyTranslator>
}
}
}
virtual bool translate(RowFilter &filters) const override // MORE - remove this version - it's not safe
virtual bool translate(RowFilter &filters) const override
{
bool mapNeeded = false;
if (translateNeeded)
Expand Down
25 changes: 23 additions & 2 deletions rtl/eclrtl/rtldynfield.hpp
View file
Open in desktop
Expand Up @@ -120,9 +120,30 @@ interface IDynamicTransform : public IInterface

interface IKeyTranslator : public IInterface
{
/*
* Describe the operations of a translator to the log
*/
virtual void describe() const = 0;
virtual bool translate(RowFilter &filters) const = 0; // MORE - this should be deprecated
virtual bool translate(RowFilter &result, IConstArrayOf<IFieldFilter> &_filters) const = 0;
/*
* Translate the field numbers of a RowFilter array in-situ. An exception will be thrown if an
* untranslatable field is encountered.
*
* @param filters The RowFilter array to be updated
* @return Indicates whether any field numbers changed
*/
virtual bool translate(RowFilter &filters) const = 0;
/*
* Translate the field numbers of a RowFilter array, creating a new RowFilter array. An exception will be thrown if an
* untranslatable field is encountered.
*
* @param filters The input RowFilter array to be translated
* @param result Updated to add translated versions of all the FieldFilters in the input
* @return Indicates whether any field numbers changed
*/
virtual bool translate(RowFilter &result, IConstArrayOf<IFieldFilter> &filters) const = 0;
/*
* Return whether any fields are translated by this translator
*/
virtual bool needsTranslate() const = 0;
};

Expand Down