HPCC-19084 Regression Test Engine should handle syntactically wrong tags in ECL files.

[AttilaVamos]

Add new error message related to '//skip' tag
Add code to handle exception on a syntactically incorrect '/skip' tag
Remove some unused imports

Signed-off-by: Attila Vamos attila.vamos@gmail.com

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Testing:

Tested manually on the when6b.ecl

[hpcc-jirabot]

https://track.hpccsystems.com/browse/HPCC-19084
Jira updated

[HPCCSmoketest]

Automated Smoketest: ❌
Sha: 268c926
Build: success
Install hpccsystems-platform-community_6.5.0-trunk0xenial_amd64.deb
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout
unittest	82	82	0	0	0
wutoolTest(Dali)	19	17	2	0	0
wutoolTest(Cassandra)	19	19	0	0	0

Wutool error(s):
Dali:1) test: WuTool::testList (F) line: 1656 /home/ati/smoketest/PR-10872/HPCC-Platform/tools/wutool/wutool.cpp

Dali:equality assertion failed

Dali:2) test: WuTool::testSortByThorTime (F) line: 1930 /home/ati/smoketest/PR-10872/HPCC-Platform/tools/wutool/wutool.cpp

Dali:assertion failed

Regression test result:

phase	total	pass	fail
setup (hthor)	11	11	0
setup (thor)	11	11	0
setup (roxie)	11	11	0
test (hthor)	0	0	0
test (thor)	0	0	0
test (roxie)	0	0	0

[Error] Error (6005): Syntax error in //skip tag! 
     file: /home/ati/smoketest/PR-10872/HPCC-Platform/testing/regress/ecl/filecompcopy.ecl:21
     text: //skip nodfu       
    

HPCC Stop: OK
Time stats:

Prep time	Build time	Package time	Install time	Start time	Test time	Stop time	Summary
30 sec (00:00:30)	1002 sec (00:16:42)	72 sec (00:01:12)	156 sec (00:02:36)	259 sec (00:04:19)	892 sec (00:14:52)	57 sec (00:00:57)	2468 sec (00:41:08)

[HPCCSmoketest]

Automated Smoketest: ❌
Sha: 7632955
Build: success
Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout
unittest	82	82	0	0	0
wutoolTest(Dali)	19	19	0	0	0
wutoolTest(Cassandra)	19	19	0	0	0

Regression test result:

phase	total	pass	fail
setup (hthor)	11	11	0
setup (thor)	11	11	0
setup (roxie)	11	11	0
test (hthor)	0	0	0
test (thor)	0	0	0
test (roxie)	0	0	0

[Error] Error (6006): Error in build suite 
     Error (6005): Syntax error in //skip tag! 
     file: /mnt/disk1/home/vamosax/smoketest/PR-10872/HPCC-Platform/testing/regress/ecl/filecompcopy.ecl:21
     text: //skip nodfu       
    Error (6005): Syntax error in //skip tag! 
     file: /mnt/disk1/home/vamosax/smoketest/PR-10872/HPCC-Platform/testing/regress/ecl/when6b.ecl:19
     text: //skip type-thorlcr tbd
    
    

HPCC Stop: OK
Time stats:

Prep time	Build time	Package time	Install time	Start time	Test time	Stop time	Summary
39 sec (00:00:39)	183 sec (00:03:03)	56 sec (00:00:56)	0 sec (00:00:00)	30 sec (00:00:30)	203 sec (00:03:23)	31 sec (00:00:31)	542 sec (00:09:02)