Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-18601 Re-evaluate package maps widget in 7.0 #10958

Merged
merged 1 commit into from May 8, 2018
Merged

HPCC-18601 Re-evaluate package maps widget in 7.0 #10958

merged 1 commit into from May 8, 2018

Conversation

miguelvazq
Copy link

@miguelvazq miguelvazq commented Mar 13, 2018 •
edited

Improving some of the code in PackageMapQueryWidget.js to take advantage
of the ECLWatch framework. U/I was not loading in 7.0.0 due
to some changes in dependencies - that has been fixed. Also, improve overall usability and
performance.

Signed-off by: Miguel Vazquez miguel.vazquez@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-18601
Jira updated

@miguelvazq
Copy link
Author

@GordonSmith Please review

@miguelvazq
Copy link
Author

@GordonSmith rebased.

GordonSmith
GordonSmith requested changes Apr 18, 2018
View reviewed changes
Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok - just some commented code to remove.

esp/src/eclwatch/PackageMapQueryWidget.js Outdated
// resize: function (args) {
// this.inherited(arguments);
// this.borderContainer.resize();
// },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code.

@richardkchapman
Copy link
Member

@miguelvazq

@miguelvazq miguelvazq closed this Apr 25, 2018
@miguelvazq miguelvazq reopened this Apr 25, 2018
@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-18601
Jira not updated (pull request already registered)

@miguelvazq
Copy link
Author

@GordonSmith Removed comments and rebased

GordonSmith
GordonSmith requested changes Apr 26, 2018
View reviewed changes
Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this will fail linting due to duplicate vars.

esp/src/eclwatch/PackageMapQueryWidget.js Outdated
var objStore = ESPPackageProcess.CreatePackageMapQueryObjectStore();
this.packagesGrid.setStore(objStore);
}
}, this.id + "PackagesGrid");

var context = this;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already declared.

esp/src/eclwatch/PackageMapQueryWidget.js
if (active === true) {
return "A";
initPackagesGrid: function () {
var context = this;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already declared.

@miguelvazq
Copy link
Author

@GordonSmith Updated.

@GordonSmith
Copy link
Member

@miguelvazq failing smoketest build.

@miguelvazq
Copy link
Author

@GordonSmith I am not seeing where the smoketest would fail? Is this suspect? Cant resolve hpcc/ESPUtil in /mnt/disk1/home/vamosax/smoketest/PR-10958/build/esp/src/tmp/eclwatch

@GordonSmith
Copy link
Member

@miguelvazq if you replace hpcc/ESPUtil with src/ESPUtil it should fix it for you (ESPUtil was moved to TS a while back).

HPCC-18601 Re-evaluate package maps widget in 7.0
58564ce 
Improving some of the code in PackageMapQueryWidget.js to take advantage
of the ECLWatch framework. U/I was not loading in 7.0.0 due
to some changes in dependencies - that has been fixed. Also, improve overall usability and
performance.

Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
@miguelvazq miguelvazq force-pushed the HPCC-18601 branch 2 times, most recently from 15c9a9d to 58564ce Compare May 7, 2018 17:48
@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.2.1511 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 58564ce
Build: success
ECL Watch: Rebuilding Site
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

Rebuild: success
Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 88 88 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 784 784 0
test (thor) 715 715 0
test (roxie) 828 828 0

HPCC Stop: OK
HPCC Uninstall: OK

@miguelvazq
Copy link
Author

@GordonSmith Should be good now.

GordonSmith
GordonSmith approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@richardkchapman richardkchapman merged commit 10f3787 into hpcc-systems:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@miguelvazq @hpcc-jirabot @richardkchapman @GordonSmith @HPCCSmoketest