HPCC-18148 Std.Date: Fix handling of of local time and DST

[dcamper]

Correct problem where daylight savings time was not automatically determined when creating new time structures from date/time parts, which resulted in incorrect "number of seconds since epoch" results.

Also added optional is_local_time argument to SecondsToParts function, CreateDateFromSeconds transform, CreateTimeFromSeconds transform, and CreateDateTimeFromSeconds transform. The new argument fixes incorrect inverse translations from SecondsFromParts(is_local_time := TRUE) results.

Signed-off-by: Dan S. Camper dan.camper@lexisnexisrisk.com

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Testing:

Manual testing, plus passing of existing and new unit tests.

[hpcc-jirabot]

https://track.hpccsystems.com/browse/HPCC-18148
Jira updated

[HPCCSmoketest]

Automated Smoketest: ❌
OS: centos 7.2.1511 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 8561832
Build: success
Install hpccsystems-platform-community_7.0.0-beta1rc1.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout
unittest	88	88	0	0	0
wutoolTest(Dali)	19	19	0	0	0
wutoolTest(Cassandra)	19	19	0	0	0

Regression test result:

phase	total	pass	fail
setup (hthor)	11	11	0
setup (thor)	11	11	0
setup (roxie)	11	11	0
test (hthor)	786	786	0
test (thor)	717	717	0
test (roxie)	830	828	2

Errors:

• test
  • roxie
    • 559. roxiepipe, 604. soapcall (targetIP=127001, goodPort=9876, blacListedPort=9875),

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time	Build time	Package time	Install time	Start time	Test time	Stop time	Summary
11 sec (00:00:11)	177 sec (00:02:57)	60 sec (00:01:00)	9 sec (00:00:09)	30 sec (00:00:30)	1683 sec (00:28:03)	17 sec (00:00:17)	1987 sec (00:33:07)

[richardkchapman]

@ghalliday Please review

[ghalliday]

This fixes my various examples, and looks logical.