Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-19252 ECLWatch reports undefined targets #11441

Merged
merged 1 commit into from Jul 20, 2018

Conversation

miguelvazq
Copy link

@miguelvazq miguelvazq commented Jul 18, 2018

Adding the new server name which shows eclserver names instead of queue names.

Signed-off by: Miguel Vazquez miguel.vazquez@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

Adding the new server name which shows eclserver names instead of queue names.

Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
@hpcc-jirabot
Copy link

@miguelvazq
Copy link
Author

@wangkx please review.

Copy link
Member

@wangkx wangkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelvazq looks fine.

@richardkchapman
Copy link
Member

Can we check that the smoketest failure is not caused by this change please.

@AttilaVamos
Copy link
Contributor

I think this error is not related to this PR.
Sometimes (very rarely) I saw this schedule2 problem on Roxie in other PRs, but I can't find any reason for it (yet). Usually it is disappear in the next test. Now I forced to core generation in Smoketest machine, check and archive if any core file appear to further investigate. So we will see.
This PR is rescheduled for test.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: c191479
Build: success
ECL Watch: Rebuilding Site
Rebuild: success
Install hpccsystems-platform-community_7.0.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 89 89 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 790 790 0
test (thor) 721 721 0
test (roxie) 861 861 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
25 sec (00:00:25) 169 sec (00:02:49) 128 sec (00:02:08) 10 sec (00:00:10) 31 sec (00:00:31) 1493 sec (00:24:53) 19 sec (00:00:19) 1875 sec (00:31:15)

@richardkchapman richardkchapman merged commit dded606 into hpcc-systems:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants