HPCC-19743 Allow disk read to directly deserialize a row without calling a transform

[ghalliday]

Currently only implemented for Thor, since this is the engine that will
gain the main benefit when spill files are dynamically spilled.

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Testing:

[hpcc-jirabot]

https://track.hpccsystems.com/browse/HPCC-19743
Jira updated

[ghalliday]

@jakesmith can you foresee this causing any problems? I've tested as best as I can, and it seems to work with Thor as it stands. It will allow more efficient dynamic spilling (and some remote reads).
@shamser please review

[ghalliday]

I will look at the failures - I hadn't run a full regression suite locally.

[ghalliday]

The failures were linked with dictionaries being serialized to disk as datasets.

[ghalliday]

@richardkchapman please can you review the translator changes.

[richardkchapman]

Translator changes look ok. Back to @shamser to review coedgen

[ghalliday]

new PR added extra test variants to sqfilt.ecl to cover cases I was slightly concerned about.

[HPCCSmoketest]

Automated Smoketest: ✅
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: d6efee5
Build: success
Install hpccsystems-platform-community_7.0.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout
unittest	89	89	0	0	0
wutoolTest(Dali)	19	19	0	0	0
wutoolTest(Cassandra)	19	19	0	0	0

Regression test result:

phase	total	pass	fail
setup (hthor)	11	11	0
setup (thor)	11	11	0
setup (roxie)	11	11	0
test (hthor)	796	796	0
test (thor)	727	727	0
test (roxie)	867	867	0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time	Build time	Package time	Install time	Start time	Test time	Stop time	Summary
12 sec (00:00:12)	169 sec (00:02:49)	61 sec (00:01:01)	9 sec (00:00:09)	30 sec (00:00:30)	1293 sec (00:21:33)	18 sec (00:00:18)	1592 sec (00:26:32)

[shamser]

@richardkchapman Code Reviewed. Looks good.