HPCC-20776 Unable to start ESP if https and no passphrase

[RussWhitehead]

If HTTPS is enabled in the ESP configuration, and no passphrase is provided,
then ESP throws and aborts. The passphrase is optional and ESP should start
without if, unless the certificates require it. This PR removes the requirement
for passphrase

Signed-off-by: Russ Whitehead william.whitehead@lexisnexis.com

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Testing:

[hpcc-jirabot]

https://track.hpccsystems.com/browse/HPCC-20776
Jira updated

[RussWhitehead]

@wangkx Please review

[wangkx]

I have not found any problem. But, I am not familiar with this area. @afishbeck could you please review?

[HPCCSmoketest]

Automated Smoketest: ✅
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 367651b
Build: success
Install hpccsystems-platform-community_7.0.0-rc3.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout
unittest	95	95	0	0	0
wutoolTest(Dali)	19	19	0	0	0
wutoolTest(Cassandra)	19	19	0	0	0

Regression test result:

phase	total	pass	fail
setup (hthor)	11	11	0
setup (thor)	11	11	0
setup (roxie)	11	11	0
test (hthor)	806	806	0
test (thor)	730	730	0
test (roxie)	879	879	0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time	Build time	Package time	Install time	Start time	Test time	Stop time	Summary
38 sec (00:00:38)	186 sec (00:03:06)	95 sec (00:01:35)	21 sec (00:00:21)	44 sec (00:00:44)	1475 sec (00:24:35)	20 sec (00:00:20)	1879 sec (00:31:19)

[afishbeck]

@RussWhitehead looks good.

[RussWhitehead]

@richardkchapman Read for merge