Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-21168 Setup ESP logging agent to only run specified services #11990

Conversation

wangkx
Copy link
Member

@wangkx wangkx commented Dec 7, 2018

The changes are for all ESP logging agents (MySQLLoggingAgent,
CassandraLoggingAgent, ESPServerLoggingAgent, and
WSLogServiceLoggingAgent).

  1. Modify setting scripts to allow users to set which logging services are
    provided by a logging agent;
  2. Create CLogAgentBase for basic functions shared by all log agents;
  3. Move agent name and agent services into CLogAgentBase;
  4. Set agent name and agent services in all log agent;
  5. Call transaction seed/ID functions only the transaction seed/ID services
    is set for the log agent;
  6. Call UpdateLog functions only the UpdateLog service is set for the log
    agent.

Signed-off-by: wangkx kevin.wang@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

The changes are for all ESP logging agents (MySQLLoggingAgent,
CassandraLoggingAgent, ESPServerLoggingAgent, and
WSLogServiceLoggingAgent).

1. Modify setting scripts to allow users to set which logging services are
provided by a logging agent;
2. Create CLogAgentBase for basic functions shared by all log agents;
3. Move agent name and agent services into CLogAgentBase;
4. Set agent name and agent services in all log agent;
5. Call transaction seed/ID functions only the transaction seed/ID services
is set for the log agent;
6. Call UpdateLog functions only the UpdateLog service is set for the log
agent.

Signed-off-by: wangkx <kevin.wang@lexisnexis.com>
@hpcc-jirabot
Copy link

@wangkx
Copy link
Member Author

wangkx commented Dec 7, 2018

@afishbeck please review this PR and https://github.com/hpcc-systems/LN/pull/899.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 249eefb
Build: success
Build: success
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 95 95 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 808 808 0
test (thor) 732 732 0
test (roxie) 881 881 0

HPCC Stop: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
22 sec (00:00:22) 189 sec (00:03:09) 0 sec (00:00:00) 2 sec (00:00:02) 18 sec (00:00:18) 1483 sec (00:24:43) 20 sec (00:00:20) 1734 sec (00:28:54)

Copy link
Member

@afishbeck afishbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardkchapman looks fine, please merge.

@richardkchapman richardkchapman merged commit e739947 into hpcc-systems:candidate-7.0.6 Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants