Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-21702 New Zap options added to ECL Watch doc #12368

Merged
merged 1 commit into from Apr 18, 2019

Conversation

g-pan
Copy link
Member

@g-pan g-pan commented Mar 28, 2019

Signed-off-by: G-Pan greg.panagiotatos@lexisnexis.com

@JamesDeFabia please review
@kunalaswani FYI, optionally review

View compiled PDF at http://10.240.32.243/view/Docs%207.0/job/AnotherDocBuild7

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

View Successful Build TEST at http://10.240.32.243/view/Docs%207.0/job/AnotherDocBuild7

@hpcc-jirabot
Copy link

Copy link
Contributor

@JamesDeFabia JamesDeFabia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss what to do with sensitive info BEFORE the step that says "Press the Apply button."

Something along the lines of:
If your ZAP package might contain sensitive information, use the utility to create a package, then sanitize it, and send manually.
If it doesn't then you can use the email feature to send automatically.

Administrator can configure the email. The (To) Email Address is
also set by the Administrator and can only be changed in the
configuration. The (From) Email Address can be set in the
configuration manager, but can be changed if desired. The Email
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration Manager (s/b title case)

@JamesDeFabia
Copy link
Contributor

@g-pan back to you

@g-pan
Copy link
Member Author

g-pan commented Apr 16, 2019

@JamesDeFabia Revised and Rebased. Please Review.

@g-pan
Copy link
Member Author

g-pan commented Apr 17, 2019

@JamesDeFabia Revised and Rebased.

@g-pan g-pan force-pushed the H21702-ZapR branch 3 times, most recently from cd83d09 to 5ac7e32 Compare April 17, 2019 20:02
Copy link
Contributor

@JamesDeFabia JamesDeFabia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one minor comment inline

Subject is required, but the Email Body is optional.</para>

<para>Press the <emphasis role="bold">Apply </emphasis>button when
all the dialog fields are filled. At that point if you checked the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...all the dialog fields are filled. Should be ...all the dialog fields are completed. (or filled in.)

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 5ac7e32
Build: success
Build: success
Install HPCC Platform
HPCC Start: OK
HPCC Stop: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
36 sec (00:00:36) 355 sec (00:05:55) 0 sec (00:00:00) 27 sec (00:00:27) 18 sec (00:00:18) 0 sec (00:00:00) 15 sec (00:00:15) 451 sec (00:07:31)

Signed-off-by: G-Pan <greg.panagiotatos@lexisnexis.com>
Copy link
Contributor

@JamesDeFabia JamesDeFabia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@richardkchapman richardkchapman merged commit 739d1ee into hpcc-systems:candidate-7.2.x Apr 18, 2019
@g-pan g-pan deleted the H21702-ZapR branch September 15, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants