Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-22300 Fix potential memory corruption in row translation #12651

Merged
merged 1 commit into from Jun 12, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions rtl/eclrtl/rtlfield.cpp
Expand Up @@ -475,14 +475,13 @@ double RtlRealTypeInfo::value(const void * self) const

size32_t RtlRealTypeInfo::build(ARowBuilder &builder, size32_t offset, const RtlFieldInfo *field, IFieldSource &source) const
{
builder.ensureCapacity(length+offset, queryName(field));
double val = source.getRealResult(field);
return buildReal(builder, offset, field, val);
}

size32_t RtlRealTypeInfo::buildReal(ARowBuilder &builder, size32_t offset, const RtlFieldInfo *field, double val) const
{
byte *dest = builder.getSelf() + offset;
byte *dest = builder.ensureCapacity(length+offset, queryName(field)) + offset;
if (length == 4)
*(float *) dest = (float) val;
else
Expand Down