Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-22584 Support new log format in WsTopology #12939

Merged
merged 1 commit into from Sep 5, 2019

Conversation

wangkx
Copy link
Member

@wangkx wangkx commented Sep 4, 2019

  1. Add readLogMessageFields() to read the information about the
    log fields in new log format;
  2. Rewrite the functions of reading last log time to support new
    log format;
  3. Move the code for GLOLastNRows into new readLastNRowsToArray()
    and clean the code;
  4. Refactor readLogFileToArray() to use IStreamLineReader for
    GLOFirstNRows, GLOLastNHours and GLOTimeRange;
  5. Clean addALogLine().

Signed-off-by: wangkx kevin.wang@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

1. Add readLogMessageFields() to read the information about the
log fields in new log format;
2. Rewrite the functions of reading last log time to support new
log format;
3. Move the code for GLOLastNRows into new readLastNRowsToArray()
and clean the code;
4. Refactor readLogFileToArray() to use IStreamLineReader for
GLOFirstNRows, GLOLastNHours and GLOTimeRange;
5. Clean addALogLine().

Signed-off-by: wangkx <kevin.wang@lexisnexis.com>
@hpcc-jirabot
Copy link

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-327.28.3.el7.x86_64)
GCC:gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Sha: f43d21c
Build: success
Build: success
Install HPCC Platform
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout elaps
unittest 116 116 0 0 0 35 sec
wutoolTest(Dali) 19 19 0 0 0 2 sec
wutoolTest(Cassandra) 19 19 0 0 0 7 sec

Regression test result:

phase total pass fail elaps
setup (hthor) 11 11 0 23 sec (00:00:23)
setup (thor) 11 11 0 45 sec (00:00:45)
setup (roxie) 11 11 0 23 sec (00:00:23)
test (hthor) 851 851 0 172 sec (00:02:52)
test (thor) 775 775 0 707 sec (00:11:47)
test (roxie) 927 927 0 418 sec (00:06:58)

HPCC Stop: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
36 sec (00:00:36) 258 sec (00:04:18) 0 sec (00:00:00) 3 sec (00:00:03) 19 sec (00:00:19) 1610 sec (00:26:50) 20 sec (00:00:20) 1946 sec (00:32:26)

@wangkx
Copy link
Member Author

wangkx commented Sep 4, 2019

This PR replaces #12882. @shamser please review.

Copy link
Contributor

@shamser shamser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangkx Reviewed. Looks good.

@richardkchapman richardkchapman merged commit d2722c3 into hpcc-systems:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants