New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-22996 Remove libtbb from rpmdeps generated dependencies #13088
HPCC-22996 Remove libtbb from rpmdeps generated dependencies #13088
Conversation
https://track.hpccsystems.com/browse/HPCC-22996 |
Perhaps we should add a file with libs / strings to remove from the rpmdeps and use grep -v -f instead of listing them on the cmdline ? |
@Michael-Gardner please review / comment. |
@mckellyln Stripped libtbb from the dependency list as expected. |
@Michael-Gardner ok - perhaps if/when we add another exception then we should switch to putting the exceptions into a file and having the grep read them from that file. |
@Michael-Gardner are you ok with this to merge ? |
@mckellyln Ok with merging. And yeah if we add any more exceptions like this we should probably think of a more succinct way of doing it. |
@ghalliday ok to merge. |
@mckellyln |
ok, I will change to 7.6.x. I need to rebase it tho because if I just change the base here there are other files involved. |
094fe09
to
9e76165
Compare
Signed-off-by: Mark Kelly <mark.kelly@lexisnexisrisk.com>
9e76165
to
050ff1d
Compare
rebased onto candidate-7.6.x |
@ghalliday ok for merge into candidate-7.6.x |
Automated Smoketest: ✅ Unit tests result:
Regression test result:
HPCC Stop: OK
|
Signed-off-by: Mark Kelly mark.kelly@lexisnexisrisk.com
Type of change:
Checklist:
Smoketest:
Testing:
Manual install and smoke test