HPCC-23771 Don't allow udp send manager to have a timeout of 0

[richardkchapman]

Signed-off-by: Richard Chapman rchapman@hpccsystems.com

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

Compiled

[hpcc-jirabot]

https://track.hpccsystems.com/browse/HPCC-23771
Jira updated

[richardkchapman]

@ghalliday Please review

[HPCCSmoketest]

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-234.ca-central-1.compute.internal
Sha: 569db25
Build: success
ECL Watch: Rebuilding Site
Install warning(s):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/watchpack/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {os:darwin,arch:any} (current: {os:linux,arch:x64})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {os:darwin,arch:any} (current: {os:linux,arch:x64})

Rebuild: success
Milestone:Install hpccsystems-platform-community_7.6.33-closedown0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout	elaps
unittest	116	116	0	0	0	41 sec
wutoolTest(Dali)	19	19	0	0	0	2 sec
wutoolTest(Cassandra)	19	19	0	0	0	8 sec

Regression test result:

phase	total	pass	fail	elaps
setup (hthor)	11	11	0	25 sec (00:00:25)
setup (thor)	11	11	0	43 sec (00:00:43)
setup (roxie)	11	11	0	22 sec (00:00:22)
test (hthor)	868	868	0	315 sec (00:05:15)
test (thor)	807	807	0	709 sec (00:11:49)
test (roxie)	949	949	0	416 sec (00:06:56)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time	Build time	Package time	Install time	Start time	Test time	Stop time	Summary
8 sec (00:00:08)	413 sec (00:06:53)	211 sec (00:03:31)	23 sec (00:00:23)	21 sec (00:00:21)	1755 sec (00:29:15)	17 sec (00:00:17)	2448 sec (00:40:48)

[HPCCSmoketest]

Automated Smoketest: ✅
OS: centos 7.7.1908 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-116.ca-central-1.compute.internal
Sha: 569db25
Build: success
ECL Watch: Rebuilding Site
Install warning(s):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/watchpack/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {os:darwin,arch:any} (current: {os:linux,arch:x64})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {os:darwin,arch:any} (current: {os:linux,arch:x64})

Rebuild: success
Milestone:Install hpccsystems-platform-community_7.6.33-closedown0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout	elaps
unittest	116	116	0	0	0	40 sec
wutoolTest(Dali)	19	19	0	0	0	1 sec
wutoolTest(Cassandra)	19	19	0	0	0	9 sec

Regression test result:

phase	total	pass	fail	elaps
setup (hthor)	11	11	0	27 sec (00:00:27)
setup (thor)	11	11	0	44 sec (00:00:44)
setup (roxie)	11	11	0	20 sec (00:00:20)
test (hthor)	868	868	0	563 sec (00:09:23)
test (thor)	807	807	0	957 sec (00:15:57)
test (roxie)	949	949	0	707 sec (00:11:47)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time	Build time	Package time	Install time	Start time	Test time	Stop time	Summary
8 sec (00:00:08)	665 sec (00:11:05)	245 sec (00:04:05)	22 sec (00:00:22)	18 sec (00:00:18)	2567 sec (00:42:47)	18 sec (00:00:18)	3543 sec (00:59:03)