Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-23898 - Can't deploy queries to Roxie under k8s #13652

Merged

Conversation

richardkchapman
Copy link
Member

Signed-off-by: Richard Chapman rchapman@hpccsystems.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Manual

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
@richardkchapman
Copy link
Member Author

@afishbeck Please review

@hpcc-jirabot
Copy link

@HPCCSmoketest
Copy link
Contributor

Process of PR-13652, label: roxie-cloud-deploy starts now.
The reason of this test is: Did not build yet.
Commit ID: d617816
Estimated completion time is ~0.9 hour(s)
centos 7.7.1908 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-116.ca-central-1.compute.internal

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-96.ca-central-1.compute.internal
Sha: d617816
Build: success
Milestone:Install hpccsystems-platform-community_7.8.7-closedown0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout elaps
unittest 120 120 0 0 0 52 sec
wutoolTest(Dali) 19 19 0 0 0 1 sec
wutoolTest(Cassandra) 19 19 0 0 0 7 sec

Regression test result:

phase total pass fail elaps
setup (hthor) 11 11 0 25 sec (00:00:25)
setup (thor) 11 11 0 43 sec (00:00:43)
setup (roxie) 11 11 0 26 sec (00:00:26)
test (hthor) 873 873 0 415 sec (00:06:55)
test (thor) 812 812 0 802 sec (00:13:22)
test (roxie) 953 953 0 404 sec (00:06:44)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
9 sec (00:00:09) 639 sec (00:10:39) 117 sec (00:01:57) 22 sec (00:00:22) 19 sec (00:00:19) 1949 sec (00:32:29) 18 sec (00:00:18) 2773 sec (00:46:13)

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.7.1908 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-116.ca-central-1.compute.internal
Sha: d617816
Build: success
Milestone:Install hpccsystems-platform-community_7.8.7-closedown0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout elaps
unittest 120 120 0 0 0 55 sec
wutoolTest(Dali) 19 19 0 0 0 2 sec
wutoolTest(Cassandra) 19 19 0 0 0 9 sec

Regression test result:

phase total pass fail elaps
setup (hthor) 11 11 0 28 sec (00:00:28)
setup (thor) 11 11 0 45 sec (00:00:45)
setup (roxie) 11 11 0 22 sec (00:00:22)
test (hthor) 873 873 0 577 sec (00:09:37)
test (thor) 812 812 0 1028 sec (00:17:08)
test (roxie) 953 953 0 710 sec (00:11:50)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
10 sec (00:00:10) 922 sec (00:15:22) 123 sec (00:02:03) 22 sec (00:00:22) 18 sec (00:00:18) 2650 sec (00:44:10) 18 sec (00:00:18) 3763 sec (01:02:43)

Copy link
Member

@afishbeck afishbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what all the implications are for file information, but otherwise looks ok as a first step.

@richardkchapman
Copy link
Member Author

Implications are we don't clone file information to say that Roxie has its own copy - with off-node storage that seems correct.

@ghalliday Please review/merge

@ghalliday ghalliday merged commit 5e01bb6 into hpcc-systems:candidate-7.8.x Apr 22, 2020
@richardkchapman richardkchapman deleted the roxie-cloud-deploy branch June 10, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants