Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-24646 Remove "--param use.id.as.filename 1" in xsltproc #14104

Conversation

xwang2713
Copy link
Member

Greg found removing this flag in xsltproc help to create correct chm with Windows hhc.exe
I built and verified the chm can be opened.

Signed-off-by: Xiaoming Wang xiaoming.wang@lexisnexis.com

@g-pan please review

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

http://10.240.61.86/view/Custom/job/CE-Docs-JIRA-24646/
http://10.240.61.86/view/Custom/job/ECLIDE-W32-JIRA-24646/

@hpcc-jirabot
Copy link

Copy link
Member

@g-pan g-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-211.ca-central-1.compute.internal
Sha: c250afe
Build: success
Milestone:Install hpccsystems-platform-community_7.10.17-closedown0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout elaps
unittest 144 144 0 0 0 74 sec
wutoolTest(Dali) 19 19 0 0 0 1 sec
wutoolTest(Cassandra) 19 19 0 0 0 8 sec

Regression test result:

phase total pass fail elaps
setup (hthor) 11 11 0 28 sec (00:00:28)
setup (thor) 11 11 0 44 sec (00:00:44)
setup (roxie) 11 11 0 21 sec (00:00:21)
test (hthor) 884 884 0 322 sec (00:05:22)
test (thor) 822 822 0 772 sec (00:12:52)
test (roxie) 964 964 0 403 sec (00:06:43)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
10 sec (00:00:10) 793 sec (00:13:13) 123 sec (00:02:03) 23 sec (00:00:23) 18 sec (00:00:18) 1847 sec (00:30:47) 19 sec (00:00:19) 2833 sec (00:47:13)

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.8.2003 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-116.ca-central-1.compute.internal
Sha: c250afe
Build: success
Milestone:Install hpccsystems-platform-community_7.10.17-closedown0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout elaps
unittest 144 144 0 0 0 74 sec
wutoolTest(Dali) 19 19 0 0 0 2 sec
wutoolTest(Cassandra) 19 19 0 0 0 8 sec

Regression test result:

phase total pass fail elaps
setup (hthor) 11 11 0 28 sec (00:00:28)
setup (thor) 11 11 0 45 sec (00:00:45)
setup (roxie) 11 11 0 20 sec (00:00:20)
test (hthor) 884 884 0 582 sec (00:09:42)
test (thor) 822 822 0 1032 sec (00:17:12)
test (roxie) 964 964 0 728 sec (00:12:08)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
9 sec (00:00:09) 1061 sec (00:17:41) 125 sec (00:02:05) 23 sec (00:00:23) 17 sec (00:00:17) 2696 sec (00:44:56) 17 sec (00:00:17) 3948 sec (01:05:48)

@richardkchapman richardkchapman merged commit b933397 into hpcc-systems:candidate-7.10.x Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants