HPCC-26013 Avoid a couple of spurious env. calls in container mode

[jakesmith]

Signed-off-by: Jake Smith jake.smith@lexisnexisrisk.com

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

https://track.hpccsystems.com/browse/HPCC-26013
Jira updated

[ghalliday]

#else
return false;

[jakesmith]

@ghalliday - whoops, now added

fixed

[HPCCSmoketest]

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-197.ca-central-1.compute.internal
Git: git version 2.9.5
Sha: c07b29d
Build: success
Milestone:Install hpccsystems-platform-community_8.2.0-rc2.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout	elaps
unittest	158	158	0	0	0	58 sec
wutoolTest(Dali)	19	19	0	0	0	1 sec
wutoolTest(Cassandra)	19	19	0	0	0	5 sec

Regression test result:

phase	total	pass	fail	elaps
setup (hthor)	9	9	0	25 sec (00:00:25)
setup (thor)	9	9	0	40 sec (00:00:40)
setup (roxie)	19	19	0	19 sec (00:00:19)
test (hthor)	981	981	0	868 sec (00:14:28)
test (thor)	892	892	0	1037 sec (00:17:17)
test (roxie)	1050	1050	0	929 sec (00:15:29)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time	Build time	Package time	Install time	Start time	Test time	Stop time	Summary
9 sec (00:00:09)	510 sec (00:08:30)	120 sec (00:02:00)	21 sec (00:00:21)	16 sec (00:00:16)	1352 sec (00:22:32)	19 sec (00:00:19)	2047 sec (00:34:07)