HPCC-27580 Revisit the ThreadList

[richardkchapman]

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

https://track.hpccsystems.com/browse/HPCC-27580
Jira updated

[HPCCSmoketest]

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-957.1.3.el7.x86_64)
Host: ip-10-20-0-199.ca-central-1.compute.internal
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Git: 2.9.5, CMake: 3.22.1, cUrl: 7.67.0, node.js: v16.13.1, npm: 8.1.2
Sha: d9d1f8e
Containerized:False
Build: success
Milestone:Install hpccsystems-platform-community_8.6.25-closedown0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test	total	passed	failed	errors	timeout	elaps
unittest	223	223	0	0	0	65 sec
wutoolTest(Dali)	19	19	0	0	0	1 sec

Regression test result:

phase	total	pass	fail	elaps
setup (hthor)	9	9	0	21 sec (00:00:21)
setup (thor)	9	9	0	38 sec (00:00:38)
setup (roxie)	20	20	0	18 sec (00:00:18)
test (hthor)	986	986	0	838 sec (00:13:58)
test (thor)	896	896	0	1000 sec (00:16:40)
test (roxie)	1056	1056	0	879 sec (00:14:39)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time	Build time	Package time	Install time	Start time	Test time	Stop time	Summary
25 sec (00:00:25)	420 sec (00:07:00)	102 sec (00:01:42)	20 sec (00:00:20)	15 sec (00:00:15)	1256 sec (00:20:56)	18 sec (00:00:18)	1856 sec (00:30:56)

[ghalliday]

Changes look good to me. Add @jakesmith to review so he can comment how significant the loss of functionality would be (especially in dali...)

[jakesmith]

Looks a good clearup to me.
The loss of the ability to query Dali threads is not something to worry about as far as I'm concerned. I don't think I've ever used/or recommended to use that feature.