Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-28507 Display file min and max skews as percentages #16687

Merged

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Nov 9, 2022

Signed-off-by: Jeremy Clements Jeremy.Clements@lexisnexisrisk.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

esp/src/eclwatch/LFDetailsWidget.js Outdated Show resolved Hide resolved
esp/src/eclwatch/DFUQueryWidget.js Outdated Show resolved Hide resolved
esp/src/src/Session.ts Outdated Show resolved Hide resolved
@jeclrsg jeclrsg force-pushed the hpcc-28507-skew-as-percentage branch 2 times, most recently from 2610a5f to 595c769 Compare November 10, 2022 20:18
esp/src/src/Utility.ts Outdated Show resolved Hide resolved
@jeclrsg jeclrsg force-pushed the hpcc-28507-skew-as-percentage branch from 595c769 to 9f60855 Compare November 11, 2022 14:31
esp/src/eclwatch/DFUQueryWidget.js Outdated Show resolved Hide resolved
esp/src/src-react/components/Files.tsx Outdated Show resolved Hide resolved
@jeclrsg jeclrsg force-pushed the hpcc-28507-skew-as-percentage branch from 9f60855 to 8b1b5ab Compare November 14, 2022 17:15
esp/src/eclwatch/DFUQueryWidget.js Outdated Show resolved Hide resolved
esp/src/eclwatch/DFUQueryWidget.js Outdated Show resolved Hide resolved
esp/src/src-react/components/Files.tsx Show resolved Hide resolved
esp/src/src-react/components/Files.tsx Show resolved Hide resolved
esp/src/src/Session.ts Outdated Show resolved Hide resolved
@jeclrsg jeclrsg force-pushed the hpcc-28507-skew-as-percentage branch from 8b1b5ab to 2ee6880 Compare November 14, 2022 18:09
esp/src/eclwatch/DFUQueryWidget.js Outdated Show resolved Hide resolved
esp/src/eclwatch/DFUQueryWidget.js Outdated Show resolved Hide resolved
@jeclrsg jeclrsg force-pushed the hpcc-28507-skew-as-percentage branch from 2ee6880 to 197ce41 Compare November 15, 2022 14:15
Signed-off-by: Jeremy Clements <Jeremy.Clements@lexisnexisrisk.com>
@jeclrsg jeclrsg force-pushed the hpcc-28507-skew-as-percentage branch from 197ce41 to 629bbaf Compare November 23, 2022 14:33
@jeclrsg
Copy link
Contributor Author

jeclrsg commented Nov 23, 2022

rebased to fix a merge conflict

@GordonSmith
Copy link
Member

@ghalliday this is ready for pull

1 similar comment
@GordonSmith
Copy link
Member

@ghalliday this is ready for pull

@ghalliday ghalliday merged commit b6e0183 into hpcc-systems:candidate-8.10.x Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants