Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-28649 Expose AKS resource group option #16767

Merged
merged 1 commit into from Jan 4, 2023
Merged

HPCC-28649 Expose AKS resource group option #16767

merged 1 commit into from Jan 4, 2023

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Dec 7, 2022 •
edited

  • Adds AKS_RESOURCE_GROUP env config option
  • Use AKS_RESOURCE_GROUP var to enable monitoring
  • Improve error message if monitoring option fails

Signed-off-by: Rodrigo Pastrana rodrigo.pastrana@lexisnexisrisk.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

https://track.hpccsystems.com/browse/HPCC-28649
Jira updated

@rpastrana
HPCC-28649 Expose AKS resource group option
ebd657d 
- Adds AKS_RESOURCE_GROUP env config option
- Use AKS_RG env var in ALA enablement option
- Improve error message if monitoring option fails
- Update README documentation

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexisrisk.com>
@rpastrana rpastrana force-pushed the HPCC-28649-independentResoursceGroups branch from 1c68d2c to ebd657d Compare December 7, 2022 15:43
@rpastrana
Copy link
Member Author

@xwang2713 please review.

@rpastrana
Copy link
Member Author

@xwang2713 reminder to review this PR.

xwang2713
xwang2713 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@xwang2713 xwang2713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rpastrana
Copy link
Member Author

@ghalliday ready for merge

@ghalliday ghalliday merged commit 8908b75 into hpcc-systems:candidate-8.10.x Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwang2713 xwang2713 xwang2713 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rpastrana @xwang2713 @ghalliday