HPCC-9975 Evaluate(module) does not like enum #4856
Conversation
|
Jira updated |
|
@ghalliday These are the main differences from the regression test: diff -I golden -I issue9975 -I hash -I master golden/minherite1.ecl.log issue9975/minherite1.ecl.log < minherite1.ecl(26,7): error C3101: Module definition contain an illegal cycle/recursive definition f
diff -I golden -I issue9975 -I hash -I master golden/minherite2.ecl.log issue9975/minherite2.ecl.log < minherite2.ecl(26,7): error C3101: Module definition contain an illegal cycle/recursive definition f
|
| @@ -4206,6 +4206,9 @@ IHqlExpression * ModuleExpander::createExpanded(IHqlExpression * scopeExpr, IHql | |||
| case no_typedef: | |||
| op = no_none; | |||
| break; | |||
| case no_enum: | |||
There was a problem hiding this comment.
This is fine. It would be more normal C++ convention to combine the cases:
case no_typedef:
case no_enum:
op = no_none;
since both cases are doing the same thing - stopping the entry from being generated.
|
Those differences are because the order the definitions get processed isn't deterministic, and the error is reported on whichever is processed first. |
Added switch case to hqlutil.cpp to ignore exported enumerated type deffinitions when declared within a module listed as an output parameter. Signed-off-by: jamienoss <james.noss@lexisnexis.com>
HPCC-9975 Evaluate(module) does not like enum Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Added switch case to hqlutil.cpp to ignore exported enumerated type deffinitions
when declared within a module listed as an output parameter.
Signed-off-by: jamienoss james.noss@lexisnexis.com