Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-10288 - Add RemoveOwnedSubFiles #5061

Merged
merged 1 commit into from Oct 24, 2013

Conversation

jakesmith
Copy link
Member

Signed-off-by: Jake Smith jake.smith@lexisnexis.com

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
@hpcc-jirabot
Copy link

Jira updated

// Try to lock all files
addFileLock(parent);
bool dirty=false;
if (lock(&dirty))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following block of code looks like it could be commoned up with some of the other clases. Not for this pull request though.

@ghalliday
Copy link
Member

Looks correct to me.

richardkchapman added a commit that referenced this pull request Oct 24, 2013
HPCC-10288 - Add RemoveOwnedSubFiles

Reviewed-By: Gavin Halliday <gavin.halliday@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
@richardkchapman richardkchapman merged commit 5ed1da5 into hpcc-systems:closedown-4.0.x Oct 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants