HPCC-11496 Avoid create/delete ClusterLock to reduce contention #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira updated |
| ~CClustersLockedSection() | ||
| { | ||
| conn.setown(querySDS().connect(xpath.str(), myProcessSession(), RTM_LOCK_WRITE, SDS_CONNECT_TIMEOUT)); | ||
| if (!conn.get()) // NB: ClusterLock is now created at File create time, so this can only true for pre-existing File's |
There was a problem hiding this comment.
Typo in comment - missing "be"
Ensure ClusterLock is present and avoid constant commits, which causes a lot of write/exclusive contention in Dali. Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
|
@richardkchapman - Updated with comments |
ghalliday
added a commit
that referenced
this pull request
May 22, 2014
HPCC-11496 Avoid create/delete ClusterLock to reduce contention Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure ClusterLock is present and avoid constant commits, which
causes a lot of write/exclusive contention in Dali.
Signed-off-by: Jake Smith jake.smith@lexisnexis.com