HPCC-11522 libmemcached plugin #6368
Conversation
|
Jira updated |
|
@richardkchapman @ghalliday please review. |
| FIND_PATH(LIBMEMCACHED_INCLUDE_DIR memcached.hpp PATHS /usr/include /usr/share/include /usr/local/include PATH_SUFFIXES libmemcached-1.0) | ||
|
|
||
| FIND_LIBRARY (LIBMEMCACHEDCORE_LIBRARY NAMES ${libmemcached_lib} PATHS /usr/lib /usr/share /usr/lib64 /usr/local/lib /usr/local/lib64) | ||
| FIND_LIBRARY (LIBMEMCACHEDUTIL_LIBRARY NAMES ${libmemcachedUtil_lib} PATHS /usr/lib /usr/share /usr/lib64 /usr/local/lib /usr/local/lib64) |
There was a problem hiding this comment.
Yes, I seem to have an issue with eclipse. I have tried many times to fix but it is un-compliant to always use ws instead of a tab.
|
On every 'get' I have asserted whether the correct routine is being used for the type that was set. I don't believe this to be concrete for the cases that the data was set externally to this plugin. If we prefixed/appended to all keys, partition and normal, then we could ensure (more than reasonably) that the data was set from the plugin. Thus preventing the user from reading externally set data, or warning of such and allowing for this to revoked along with the type assertion. |
|
I don't think that forcing the data to be set by this plugin if it is going to be read by this plugin is a good idea - seems like you are restricting users from doing something they might reasonably want to do for no real good reason. |
|
@jamienoss Please rebase |
jamienoss
force-pushed
the
issue11522-support-memcached
branch
2 times, most recently
from
7336762
to
44123ad
Compare
|
@ghalliday updated. |
| " STRING MGetString(CONST VARSTRING servers, CONST VARSTRING key, CONST VARSTRING partitionKey = 'root') : cpp,action,context,entrypoint='MGetStr'; \n" | ||
| " VARSTRING MGetVarstring(CONST VARSTRING servers, CONST VARSTRING key, CONST VARSTRING partitionKey = 'root') : cpp,action,context,entrypoint='MGetVarStr'; \n" | ||
| " UNICODE MGetUnicode(CONST VARSTRING servers, CONST VARSTRING key, CONST VARSTRING partitionKey = 'root') : cpp,action,context,entrypoint='MGetUChar'; \n" | ||
| " VARUNICODE MGetVarunicode(CONST VARSTRING servers, CONST VARSTRING key, CONST VARSTRING partitionKey = 'root') : cpp,action,context,entrypoint='MGetVarUChar'; \n" |
jamienoss
force-pushed
the
issue11522-support-memcached
branch
from
e6b86e0
to
a6bdd13
Compare
|
@ghalliday back to you. I didn't change the allServerCheck, see corresponding message. |
| ############################################################################## */ | ||
|
|
||
| export memcached := SERVICE : plugin('memcached') | ||
| BOOLEAN MSetUnicode(CONST VARSTRING servers, CONST VARSTRING key, CONST UNICODE value, CONST VARSTRING partitionKey = 'root', UNSIGNED4 expire = 0) : cpp,action,context,entrypoint='MSet'; |
There was a problem hiding this comment.
I wonder if these should remove the M prefix. The scope is already qualified by memcached.
The reason for bringing it up is that if we also provide a redis implementation it would make sense for the functions to be called the same - assuming they can have the same prototypes.
|
@jamienoss Definitely looking much closer - a few minor comments, and one problem with ctx. There are two outstanding questions.
|
Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
|
Moved to #6686 |
Previously: hpcc-systems#6368 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 & hpcc-systems#6686 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 & hpcc-systems#6686 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 & hpcc-systems#6686 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 & hpcc-systems#6686 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Previously: hpcc-systems#6368 & hpcc-systems#6686 Signed-off-by: jamienoss <james.noss@lexisnexis.com>
Signed-off-by: jamienoss james.noss@lexisnexis.com