HPCC-12234 - Should warn if admin is removed #6528
Conversation
|
Jira updated |
|
@GordonSmith Please review. |
|
Looks fine |
|
This looks to me as though it will prompt whenever you remove any use from admin group. The Jira was requesting specifically that we check if you are about to remove yourself from admin group (since you can't undo it). |
|
I feel that we need to give an administrator a warning (maybe for all instances removal and addition) that they are about to make a change as big as removing a user from an admin group which includes removing themselves. |
|
By warning any time any user is removed from the admin group, you make it less likely that they will pay any attention to the warning for the much more serious situation when they remove themselves. |
miguelvazq
force-pushed
the
HPCC-12234
branch
from
b3cbf37
to
0e7d8e3
Compare
|
I have modified the code to warn only if you are about to lock yourself out of the admin group using some utilities Gordon has implemented in the framework. @GordonSmith Please re-review. |
|
Can you fix the commit message to conform to guidelines (no - before the summary line) please |
miguelvazq
force-pushed
the
HPCC-12234
branch
from
0e7d8e3
to
46f0cc7
Compare
|
@richardkchapman Commit message fixed. |
|
@GordonSmith Please re-review |
| if (this.inherited(arguments)) | ||
| return; | ||
|
|
||
| WsAccount.MyAccount({ | ||
| }).then(function (response) { |
There was a problem hiding this comment.
(Minor) - Indentation is wrong.
Whenever an administrator removes themselves from being a member of "Administrators" they can potentially lock themselves out of the group due to a auto save feature within ECL Watch. Now they will receive a confirm warning them that they are about to lock themselves out of the admin group. Signed-off-by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
miguelvazq
force-pushed
the
HPCC-12234
branch
from
46f0cc7
to
c574669
Compare
|
@GordonSmith changes made. |
|
Looks fine - Did you open a Jira for the "dojoConfig.isAdmin"? |
|
Yes, I have. Here is the issue. https://track.hpccsystems.com/browse/HPCC-10688 |
HPCC-12234 - Should warn if admin is removed Reviewed-By: Gordon Smith <gordon.smith@lexisnexis.com> Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Whenever an administrator removes themselves from being a member of "Administrators" they can potentially lock themselves out of the group due to a auto save feature within ECL Watch. They will continue to be locked out until another administrator adds them back to be a member of administrators. We now provide a confirm dialog to notify the user that they are about to remove the user from being a member of administrator with this commit.
Signed-off: Miguel Vazquez miguel.vazquez@lexisnexis.com