HPCC-12480 SSL_connect: incorrect use of return value in securesocket #6662
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSecureSocket::secure_connect() is incorrectly checking the return code from SSL_connect() by ignoring that fact that a return of 0 is also an error. This fix changes the check from 'if(err < 0)' to 'if(err <= 0)' Signed-off-by: William Whitehead <william.whitehead@lexisnexis.com>
|
https://track.hpccsystems.com/browse/HPCC-12480 |
richardkchapman
added a commit
that referenced
this pull request
Nov 24, 2014
HPCC-12480 SSL_connect: incorrect use of return value in securesocket Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSecureSocket::secure_connect() is incorrectly checking the return code from
SSL_connect() by ignoring that fact that a return of 0 is also an error. This
fix changes the check from 'if(err < 0)' to 'if(err <= 0)'
Signed-off-by: William Whitehead william.whitehead@lexisnexis.com