HPCC-12981 Thor may cores on second job that uses python #6966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://track.hpccsystems.com/browse/HPCC-12981 |
|
@jakesmith @ghalliday Please review |
|
typo' in commit message [cores] |
|
Can't see any issues, same as javaembed fix so.. |
Unloading then reloading the pyembed plugin can lead to cores - particularly if imported python modules such as numpy have cached data. We hit similar issues in other embedded languages, and 'solved' them by preventing the relevant embed plugin from unloading Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
richardkchapman
force-pushed
the
python-no-unload
branch
from
81fafe7
to
950fd61
Compare
|
Fixed typo |
ghalliday
added a commit
that referenced
this pull request
Feb 11, 2015
HPCC-12981 Thor may cores on second job that uses python Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
|
If we had a flag on plugins, that Thor could query as it loaded the plugin list from the workunit, that told it to never release said plugin.. And if so, is that the approach we should really take moving forward ? |
|
It would achieve the same thing but not sure it's any cleaner. I think we had a similar discussion when this came up for java case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unloading then reloading the pyembed plugin can lead to cores - particularly
if imported python modules such as numpy have cached data.
We hit similar issues in other embedded languages, and 'solved' them by
preventing the relevant embed plugin from unloading
Signed-off-by: Richard Chapman rchapman@hpccsystems.com