Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-15307 Added libmemcached source build to cmake #8492

Merged

Conversation

Michael-Gardner
Copy link
Contributor

Signed-off-by: Michael Gardner michael.gardner@lexisnexis.com

Signed-off-by: Michael Gardner <michael.gardner@lexisnexis.com>
@hpcc-jirabot
Copy link

@Michael-Gardner
Copy link
Contributor Author

@jamienoss Please take a look when you get a chance.

  • Removed everything other than naming from ADD_PLUGIN call.
  • Now we fetch and build libuv 1.0.10 from source
  • then we import the .so into our project and use that target directly in our add_target_libraries call
  • install as file, with correct permissions into lib

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest
Sha: bb17cf1
Build: success
Install hpccsystems-platform-community_6.0.0-rc1.el6.x86_64.rpm
HPCC Start: OK
HPCC Stop: OK
HPCC Uninstall: OK

@Michael-Gardner
Copy link
Contributor Author

@richardkchapman Lorraine informed me that Jamie won't be in for a while to look over this PR. Any suggestions on who else should take a look at it? My first thought would be Ming?

@richardkchapman
Copy link
Member

@xwang2713 Please review

@xwang2713
Copy link
Member

xwang2713 commented Apr 18, 2016

HPCC libmemcached.so linked to libmemcached.so.11. Should it need link to libmemcached.so.11.0.0? It does for rpm/deb package install.
Maybe not since we link libmemcached.so.11.0.0 directly

@Michael-Gardner
Copy link
Contributor Author

@xwang2713 I just installed the package on centos 6 and it has symlinks for libmemcached.so, libmemcached.so.11, which both point to libmemcached.so.11.0.0 under /opt/HPCCSystems/lib/.

I also checked the plugin and it's linking against libmemcached.so.11 which in turn is actually libmemcached.so.11.0.0 so it looks like everything is good. Is this not how you're seeing it?

@xwang2713
Copy link
Member

yes. The code looks good

@Michael-Gardner
Copy link
Contributor Author

perfect. @richardkchapman should be ready for your eyes

@richardkchapman richardkchapman merged commit cefe6d6 into hpcc-systems:candidate-6.0.0 Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants