HPCC-15299 Protect multi writer getWriter from race condition #8541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IRowMultiWriterReader::getWriter() implementation incremented a unprotected writer count, used to determine end of reading. It's thread-unsafeness could cause premature termination of the reader side. NB: this is only used by the unsorted parallel join helper. The race condition can cause the join to prematurely stop and potentiall cause a timeout error when joining the remaining worker threads [~CMulticoreUnorderedJoinHelper worker[xx] join timed out" Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
|
https://track.hpccsystems.com/browse/HPCC-15299 |
|
@ghalliday - please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IRowMultiWriterReader::getWriter() implementation incremented
a unprotected writer count, used to determine end of reading.
It's thread-unsafeness could cause premature termination of
the reader side.
NB: this is only used by the unsorted parallel join helper.
The race condition can cause the join to prematurely stop and
potentiall cause a timeout error when joining the remaining worker
threads [~CMulticoreUnorderedJoinHelper worker[xx] join timed out"
Signed-off-by: Jake Smith jake.smith@lexisnexis.com