Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-15878 - Minor leaks reported from Valgrind #8869

Merged
merged 1 commit into from Jul 11, 2016

Conversation

richardkchapman
Copy link
Member

Signed-off-by: Richard Chapman rchapman@hpccsystems.com

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
@hpcc-jirabot
Copy link

@richardkchapman
Copy link
Member Author

@afishbeck Please review

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest
Sha: 24b44aa
Build: success
Install hpccsystems-platform-community_6.1.0-trunk0.el6.x86_64.rpm
HPCC Start: OK
HPCC Stop: OK
HPCC Uninstall: OK

@ghalliday
Copy link
Member

Should this target 6.0.4?

@afishbeck
Copy link
Member

@richardkchapman looks good.

@richardkchapman
Copy link
Member Author

@ghalliday I don't think it needs to target 6.0.4 - the leaks are one-off so won't actually cause a problem other than polluting the leak check reports - though I suppose that in itself might be a reason to target 6.0.4

I don't have strong feelings either way.

@ghalliday ghalliday merged commit 9e3774e into hpcc-systems:master Jul 11, 2016
@richardkchapman richardkchapman deleted the valgrind-errors branch July 23, 2017 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants