HPCC-16013 Add a config option to enable/disable Views Security Feature #8949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garonsky Please review |
| @@ -314,6 +314,15 @@ | |||
| </xs:appinfo> | |||
| </xs:annotation> | |||
| </xs:attribute> | |||
|
|
|||
|
Extra lines but otherwise looks good. |
Added a new boolean "checkViewPermissions" flag to configuration. When set, this enables the view scope feature that verifies users have permission to access file/column pairs referenced in a view-enabled query Signed-off-by: Russ Whitehead <william.whitehead@lexisnexis.com>
RussWhitehead
force-pushed
the
CheckViewScans
branch
from
584a277
to
e6a8f35
Compare
|
@garonsky Removed blank lines |
|
Automated Smoketest HPCC Stop: OK |
|
@RussWhitehead which PR contains the check? |
|
@ghalliday The check for this flag has not been added yet, @sukhong will add it next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new boolean "checkViewPermissions" flag to configuration. When set,
this signals ESP to enable the view scope feature that verifies users have permission to
access file/column pairs referenced in a view-enabled query (ESP modifications via
a different Jira/PR)
Signed-off-by: Russ Whitehead william.whitehead@lexisnexis.com