HPCC-12131 Xref Upgrade #9107
HPCC-12131 Xref Upgrade #9107
Conversation
|
@GordonSmith Please review. |
|
https://track.hpccsystems.com/browse/HPCC-12131 |
miguelvazq
force-pushed
the
XrefUpgrade
branch
from
00d1e94
to
25fd2c7
Compare
| @@ -0,0 +1,52 @@ | |||
| /*############################################################################## | |||
| # HPCC SYSTEMS software Copyright (C) 2012 HPCC Systems®. | |||
There was a problem hiding this comment.
Actually I believe we don't need this copyright message in each file any more as the single licence.txt should suffice?
There was a problem hiding this comment.
@fvillanustre Can you comment on what our policy on copyright messages in files needs to be?
| // Hitched actions --- | ||
| _onAutoRefresh: function (event) { | ||
| this.wu.disableMonitor(!this.widget.AutoRefresh.get("checked")); | ||
| }, |
There was a problem hiding this comment.
This method should be removed?
| }, | ||
| _onRefresh: function (event) { | ||
| this.wu.refresh(true); | ||
| }, |
| }, | ||
| _onGenerate: function (event) { | ||
|
|
||
| }, |
|
|
||
| _onCancel: function (event) { | ||
|
|
||
| }, |
|
|
||
| initTab: function () { | ||
| var currSel = this.getSelectedChild(); | ||
| if (currSel.id == this.widget._FoundFiles.id && !this.widget._FoundFiles.__hpcc_initalized) { |
There was a problem hiding this comment.
FYI: At some point all these "==" will be replaced with "===" (I will be turning on the linting test for it).
There was a problem hiding this comment.
I started seeing those in your code review and the for (key will now == for (var key
| id: this.id + "Generate", | ||
| disabled: false, | ||
| onClick: function (val) { | ||
| if (confirm("Running this process may take a long time and will put a heavy strain on the servers. Do you wish to continue?")) { |
| context.dialog.show(); | ||
| }, | ||
| label: "Errors/Warnings" | ||
| }).placeAt(this.directories.domNode, "after");*/ |
| new ToolbarSeparator().placeAt(this.cancel.domNode, "after"); | ||
| /*new ToolbarSeparator().placeAt(this.errorWarnings.domNode, "after"); | ||
| new ToolbarSeparator().placeAt(this.openButton.domNode, "after"); | ||
| new ToolbarSeparator().placeAt(this.foundFiles.domNode, "before");*/ |
| return retVal; | ||
| return { | ||
| Name: "SuperFiles" | ||
| }*/ |
| }); | ||
| }); | ||
| context.store.setData(newRows); | ||
| context.grid.set("query", /*this.getFilter()*/{}); |
There was a problem hiding this comment.
remove commentedd code and all refs to filters?
|
@miguelvazq Back to you |
miguelvazq
force-pushed
the
XrefUpgrade
branch
from
25fd2c7
to
b7dd369
Compare
|
@GordonSmith Updated |
| @@ -277,6 +290,9 @@ define({root: | |||
| Log: "Log", | |||
| Logs: "Logs", | |||
| log_analysis_1: "log_analysis_1*", | |||
| LostFile: "Lost Files:", | |||
| LostFile2: "Lost File:", | |||
There was a problem hiding this comment.
Are the ":" going to be moved into the HTML?
| @@ -344,6 +364,9 @@ define({root: | |||
| Operations: "Operations", | |||
| Options: "Options", | |||
| OriginalFile: "Original File", | |||
| OrphanFile: "Orphan Files:", | |||
| OrphanFile2: "Orphan File:", | |||
There was a problem hiding this comment.
Are the ":" going to be moved into the HTML?
| @@ -556,12 +587,15 @@ define({root: | |||
| title_AvailableGroupPermissions: "Available Group Permissions", | |||
| title_ClusterInfo: "Groups", | |||
| title_CodeGeneratorPermissions: "Code Generator Permissions", | |||
| title_DirectoriesFor: "Directories for:", | |||
There was a problem hiding this comment.
Are the ":" going to be moved into the HTML?
| title_DFUQuery: "Logical Files", | ||
| title_DFUWUDetails: "DFU Workunit", | ||
| title_DiskUsage: "Disk Usage", | ||
| title_ECLPlayground: "ECL Playground", | ||
| title_ErrorsWarnings: "Errors/Warnings for:", |
There was a problem hiding this comment.
Are the ":" going to be moved into the HTML?
| title_EventScheduleWorkunit: "Event Scheduler", | ||
| title_FileScopeDefaultPermissions: "Default permissions of files", | ||
| title_FoundFilesFor: "Found files for:", |
There was a problem hiding this comment.
Are the ":" going to be moved into the HTML?
| @@ -579,7 +613,9 @@ define({root: | |||
| title_LZBrowse: "Landing Zones", | |||
| title_MemberOf: "Member Of", | |||
| title_Members: "Members", | |||
| title_LostFilesFor: "Lost files for:", | |||
There was a problem hiding this comment.
Are the ":" going to be moved into the HTML?
| title_LibrariesUsed: "Libraries Used", | ||
| title_OrphanFilesFor: "Orphan files for:", |
There was a problem hiding this comment.
Are the ":" going to be moved into the HTML?
| @@ -248,10 +257,14 @@ define({root: | |||
| Largest: "Largest", | |||
| LargestFile: "Largest File", | |||
| LargestSize: "Largest Size", | |||
| LastMessage: "Last Message", | |||
| LastMessage2: "Last Message", | |||
There was a problem hiding this comment.
LastMessage2 Not needed (same as LastMessage)
| LastName: "Last Name", | ||
| LastNDays: "Last N Days", | ||
| LastNHours: "Last N Hours", | ||
| LastNRows: "Last N Rows", | ||
| LastRun: "Last Run", | ||
| LastRun2: "Last Run", |
There was a problem hiding this comment.
LastRun2 duplicate of LastRun
|
@miguelvazq Back to you |
miguelvazq
force-pushed
the
XrefUpgrade
branch
from
b7dd369
to
dd422cf
Compare
|
@GordonSmith updated. |
miguelvazq
force-pushed
the
XrefUpgrade
branch
2 times, most recently
from
0849c7d
to
f6f50a9
Compare
| Name: {label: this.i18n.Name, width:100, sortable: false}, | ||
| Modified: {label: this.i18n.Modified, width: 30, sortable: true}, | ||
| Parts: {label: this.i18n.Parts, width: 30, sortable: true}, | ||
| Size: {label: this.i18n.Size, width: 30, sortable: true}, |
| this.refreshGrid(); | ||
| }, | ||
|
|
||
| createGrid: function (domID) {\ |
| } | ||
| }, | ||
| Modified: {label: this.i18n.LastRun, width: 30, sortable: false}, | ||
| Status: {label: this.i18n.LastMessage, width: 30, sortable: false}, |
| this.store.getChildren = function (parent, options) { | ||
| var retVal = this.query({__hpcc_parentName: parent.__hpcc_id}, options); | ||
| return retVal; | ||
| };*/ |
| id: this.id + "Generate", | ||
| disabled: false, | ||
| onClick: function (val) { | ||
| if (confirm("Running this process may take a long time and will put a heavy strain on the servers. Do you wish to continue?")) { |
| context.dialog.show(); | ||
| }, | ||
| label: "Errors/Warnings" | ||
| }).placeAt(this.directories.domNode, "after");*/ |
There was a problem hiding this comment.
Commented code still needs removing
| new ToolbarSeparator().placeAt(this.cancel.domNode, "after"); | ||
| /*new ToolbarSeparator().placeAt(this.errorWarnings.domNode, "after"); | ||
| new ToolbarSeparator().placeAt(this.openButton.domNode, "after"); | ||
| new ToolbarSeparator().placeAt(this.foundFiles.domNode, "before");*/ |
| return retVal; | ||
| return { | ||
| Name: "SuperFiles" | ||
| }*/ |
| }); | ||
| }); | ||
| context.store.setData(newRows); | ||
| context.grid.set("query", /*this.getFilter()*/{}); |
| id = this.createChildTabID(id); | ||
| var retVal = registry.byId(id); | ||
| if (!retVal) { | ||
| var context = this; |
miguelvazq
force-pushed
the
XrefUpgrade
branch
2 times, most recently
from
3195cbd
to
bc84374
Compare
|
@GordonSmith I removed an accidental file that was added into templates. The ones with the commented code comments. All else was updated. |
Incorporate Xref into the new ecl watch paradigm. Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
miguelvazq
force-pushed
the
XrefUpgrade
branch
from
bc84374
to
5a0fb3b
Compare
|
Automated Smoketest HPCC Stop: OK |
Incorporate Xref into the new ecl watch paradigm.
Signed-off by: Miguel Vazquez miguel.vazquez@lexisnexis.com