Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-15803 Security Advance menu #9646

Merged
merged 1 commit into from Mar 15, 2017
Merged

HPCC-15803 Security Advance menu #9646

merged 1 commit into from Mar 15, 2017

Conversation

g-pan
Copy link
Member

@g-pan g-pan commented Mar 1, 2017

Fix HPCC-15803 Document Advanced (Security) Menu
Document the Advanced (Security) Menu in ECLWatch.

@miguelvazq please review
@RichardTaylorHPCC please review
@JamesDeFabia OPTIONALLY please review

Signed-off-by: G-Pan greg.panagiotatos@lexisnexis.com

Type of change:

  • [ x ] This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • [ x ] My code follows the code style of this project.
    • [ x ] My code does not create any new warnings from compiler, build system, or lint.
  • [ x ] The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • [ x ] My change requires a change to the documentation.
    • [ x ] I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • [ X ] The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browers
    • The component(s) render as expected

Testing:

Tested by building the doc set, with this change.
Doc built properly.

@g-pan g-pan changed the title H15803 security advance menu HPCC-15803 Security Advance menu Mar 1, 2017
miguelvazq
miguelvazq reviewed Mar 3, 2017
View reviewed changes
docs/Installing_and_RunningTheHPCCPlatform/Inst-Mods/UserSecurityMaint.xml Outdated
security needs to be enabled in your system configuration in order to use
File or Workunit Scope security on your system.</para>

<!-- /*Nother Note: Might be a good idea here to either include the doc for configuring your system to use File or Workunit scopes, or to specify how right here */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Another?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a non-printing /comment/ only displays in the source file,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still should be typo-free...

@g-pan
Copy link
Member Author

g-pan commented Mar 14, 2017

Revised.

@richardkchapman
Copy link
Member

Looks good - can you squash to a single commit please and I will merge

@g-pan
HPCC-15803 Document Advanced (Security) Menu
cbcaf94 
Fix HPCC-15803 Document Advanced (Security) Menu
Document the Advanced (Security) Menu in ECLWatch.

Signed-off-by: G-Pan <greg.panagiotatos@lexisnexis.com>
@g-pan g-pan force-pushed the H15803-SecurityAdvanceMenu branch from c31f009 to cbcaf94 Compare March 14, 2017 16:07
@g-pan
Copy link
Member Author

g-pan commented Mar 14, 2017

Squashed.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
Sha: cbcaf94
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 65 93.026 seconds

Install hpccsystems-platform-community_6.2.1-documentation0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 88 88 0 0 0

HPCC Stop: OK
HPCC Uninstall: OK

@richardkchapman richardkchapman merged commit 92b3687 into hpcc-systems:candidate-6.2.x Mar 15, 2017
@g-pan g-pan deleted the H15803-SecurityAdvanceMenu branch May 30, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardkchapman richardkchapman richardkchapman left review comments

@miguelvazq miguelvazq miguelvazq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@g-pan @richardkchapman @HPCCSmoketest @miguelvazq