New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-17216 Output each statistic on a single line (in batch mode) #9694
HPCC-17216 Output each statistic on a single line (in batch mode) #9694
Conversation
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
https://track.hpccsystems.com/browse/HPCC-17216 |
@shamser please review. |
Tested by running on the regression suite and checking stats output file. |
Automated Smoketest: ✅
Install hpccsystems-platform-community_6.3.0-trunk0.el7.x86_64.rpm Unit tests result:
HPCC Stop: OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghalliday The code looks like it is unsetting rather than setting the XML_LineBreakAttribute bit?
@@ -9031,7 +9031,7 @@ extern WORKUNIT_API void exportWorkUnitToXMLFile(const IConstWorkUnit *wu, const | |||
IPropertyTree * stats = p->queryPropTree("Statistics"); | |||
if (stats) | |||
{ | |||
saveXML(statsFilename, stats, 0, XML_Format|XML_SortTags|extraXmlFlags); | |||
saveXML(statsFilename, stats, 0, (XML_Format|XML_SortTags|extraXmlFlags) & ~XML_LineBreakAttributes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghalliday Doesn't this unset the XML_LineBreakAttribute bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is the intention (no linebreaks between attributes...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shamser Yes - that is what I want to do, have all the attributes on a single line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XML_Format is a combination of multiple bits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should get my eyes tested (misread the ticket)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardkchapman Code reviewed ok.
Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com
Type of change:
Checklist:
Testing: