Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE-735 Add option to disable GraphControl #412

Merged
merged 1 commit into from
Mar 14, 2018

Conversation

GordonSmith
Copy link
Member

Signed-off-by: Gordon Smith gordonjsmith@gmail.com

@GordonSmith
Copy link
Member Author

GordonSmith commented Mar 2, 2018

@dehilsterlexis please review.
@richardkchapman not ready for pull, need to decide if we default this off or on.

@GordonSmith GordonSmith force-pushed the IDE-735 branch 2 times, most recently from 67df3b6 to 0e99cc4 Compare March 3, 2018 07:33
@GordonSmith
Copy link
Member Author

@dehilsterlexis bump

Signed-off-by: Gordon Smith <gordonjsmith@gmail.com>
@dehilsterlexis
Copy link
Contributor

@GordonSmith looks good

@richardkchapman
Copy link
Member

@GordonSmith What was the decision re default?

@GordonSmith
Copy link
Member Author

@richardkchapman Going to default to on - so PR can be taken as is.

@richardkchapman
Copy link
Member

"On" meaning disabled ?

@dehilsterlexis
Copy link
Contributor

@richardkchapman yes

@richardkchapman richardkchapman merged commit 953b811 into hpcc-systems:candidate-6.4.14 Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants