Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockUntilExists doesn't work the same for the two watchers #5

Closed
srid opened this issue May 28, 2013 · 1 comment
Closed

BlockUntilExists doesn't work the same for the two watchers #5

srid opened this issue May 28, 2013 · 1 comment
Labels
bug

Comments

@srid
Copy link
Contributor

srid commented May 28, 2013

the function comment states blocks until the missing file comes into existence. If the file already exists, block until it is recreated - yet the polling watcher returns immediately if the file exists.

i think the inotify watcher should do the same, else there is a potential race condition in tail.go:reopen.
@ghost ghost assigned srid May 28, 2013
@srid srid mentioned this issue May 28, 2013
Merged
srid pushed a commit that referenced this issue May 28, 2013
Merge pull request #6 from srid/bug99139_copytruncate
b664e9f 
copytruncate support,

truncation detection for both inotify and polling file watchers along with test cases, plus a fix for issue #5.
@srid
Copy link
Contributor Author

srid commented May 28, 2013

fixed in commit 644891e

@srid srid closed this as completed May 28, 2013
@srid srid removed their assignment Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srid