New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[goolf-1.4.10] PyMOL and {devel}[goolf-1.4.10] GLEW (REVIEW) #1405
Conversation
Automatic reply from Jenkins: Can I test this? |
Test report by @a-mazur |
premakeopts = 'export SYSTEM=linux && export GLEW_DEST=%(installdir)s && ' | ||
|
||
# and we do "make all && make install.all" | ||
makeopts = 'all && make install.all' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be buildopts
, Jenkins will not like this (makeopts
is no longer supported in EasyBuild v2.0)
added missing dependencies
Test report by @a-mazur |
|
||
python = 'Python' | ||
pythonversion = '2.7.5' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include a versionsuffix
based on this:
versionsuffix = '-%s-%s' % (python, pythonversion)
@a-mazur: I would be in favor of replacing the Thoughts? If we don't mind holding this one until #1226 is ready and merged, we can update this PR when #1226 is merged (no use in doing it earlier, since #1226 is not ready yet). |
@boegel: I have no problem with waiting for clean Mesa easyconfig. Is it fine otherwise? |
Jenkins: ok to test |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Jenkins: test this please |
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3173/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
# we setup as env vars the system to compile and the install dir | ||
prebuildopts = 'SYSTEM=linux && export GLEW_DEST=%(installdir)s && ' | ||
|
||
# and we do "make all && make install.all" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L27 redundant
@a-mazur: this is largely ok, just finish up the last touches |
@a-mazur, this PR is being closed for the following reason(s): no activity for > 6 months. |
PyMOL is an important app for Structural Biology. It would be nice to have it in EB.
There is a newer version 1.7.4.0 but it does not compile correctly