Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[goolf-1.4.10] PyMOL and {devel}[goolf-1.4.10] GLEW (REVIEW) #1405

Closed
wants to merge 4 commits into from

Conversation

a-mazur
Copy link
Contributor

@a-mazur a-mazur commented Feb 13, 2015

PyMOL is an important app for Structural Biology. It would be nice to have it in EB.
There is a newer version 1.7.4.0 but it does not compile correctly

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@a-mazur
Copy link
Contributor Author

a-mazur commented Feb 13, 2015

Test report by @a-mazur
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
Linux centos 6.5, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/82c84134eb81e4e14977 for a full test report.

premakeopts = 'export SYSTEM=linux && export GLEW_DEST=%(installdir)s && '

# and we do "make all && make install.all"
makeopts = 'all && make install.all'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be buildopts, Jenkins will not like this (makeopts is no longer supported in EasyBuild v2.0)

@a-mazur
Copy link
Contributor Author

a-mazur commented Feb 16, 2015

Test report by @a-mazur
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
Linux centos 6.5, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/8dc202e76577d4afb9ea for a full test report.


python = 'Python'
pythonversion = '2.7.5'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include a versionsuffix based on this:

versionsuffix = '-%s-%s' % (python, pythonversion)

@boegel
Copy link
Member

boegel commented Feb 16, 2015

@a-mazur: I would be in favor of replacing the Mesa easyconfig you include here with the one being contributed in #1226, since that one doesn't include any OS dependencies anymore...

Thoughts?

If we don't mind holding this one until #1226 is ready and merged, we can update this PR when #1226 is merged (no use in doing it earlier, since #1226 is not ready yet).

@a-mazur
Copy link
Contributor Author

a-mazur commented Feb 16, 2015

@boegel: I have no problem with waiting for clean Mesa easyconfig. Is it fine otherwise?

@boegel
Copy link
Member

boegel commented Feb 16, 2015

@a-mazur: looks fine otherwise, yeah, let me trigger Jenkins too and then follow-up once #1226 makes it in (maybe state that you're waiting for that one in that PR)

@boegel
Copy link
Member

boegel commented Feb 16, 2015

Jenkins: ok to test

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2364/
Test FAILed.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2863/
Test FAILed.

@boegel
Copy link
Member

boegel commented May 31, 2015

Jenkins: test this please

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3173/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3173/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

# we setup as env vars the system to compile and the install dir
prebuildopts = 'SYSTEM=linux && export GLEW_DEST=%(installdir)s && '

# and we do "make all && make install.all"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L27 redundant

@fgeorgatos
Copy link
Contributor

@a-mazur: this is largely ok, just finish up the last touches

@boegel boegel modified the milestone: 3.x May 2, 2017
@migueldiascosta
Copy link
Member

@a-mazur, this PR is being closed for the following reason(s): no activity for > 6 months.
Please don't hesitate to reopen this PR or add a comment if you feel this contribution is still relevant.
For more information on our policy w.r.t. closing PRs, see https://easybuild.readthedocs.io/en/latest/Contributing.html#why-a-pull-request-may-be-closed-by-a-maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants