Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a unit test against borken module use #1756

Closed
fgeorgatos opened this issue May 11, 2016 · 7 comments
Closed

Have a unit test against borken module use #1756

fgeorgatos opened this issue May 11, 2016 · 7 comments
Milestone

Comments

@fgeorgatos
Copy link
Collaborator

No description provided.

@boegel
Copy link
Member

boegel commented May 11, 2016

module use /tmp/modules
echo $MODULEPATH
bash
echo $MODULEPATH

@fgeorgatos
Copy link
Collaborator Author

fgeorgatos commented May 11, 2016

reference of the bug against recent fedora, patched last month:
https://bugzilla.redhat.com/show_bug.cgi?id=1326075

@fgeorgatos
Copy link
Collaborator Author

fgeorgatos commented May 11, 2016

Example of the bug, see $MODULEPATH modifications near the end, upon bash invocation:

[root@bright-lmod ~]# wget ftp://195.220.108.108/linux/epel/6/x86_64/Lmod-6.0.15-2.el6.noarch.rpm
[...]
[root@bright-lmod ~]# md5sum Lmod-6.0.15-2.el6.noarch.rpm
36d074c7875a02d32f227abb4a553a78  Lmod-6.0.15-2.el6.noarch.rpm
[root@bright-lmod ~]# yum localinstall !$
yum localinstall Lmod-6.0.15-2.el6.noarch.rpm
[...]
Installed:
  Lmod.noarch 0:6.0.15-2.el6

Complete!
[root@bright-lmod ~]# su - fgeorgatos
Last login: Fri May  6 14:32:36 CEST 2016 from 46.17.164.10 on pts/3
[fgeorgatos@bright-lmod ~]$ echo $MODULEPATH
/etc/modulefiles:/usr/share/modulefiles:/usr/share/Modules/modulefiles:/usr/share/modulefiles/Linux:/usr/share/modulefiles/Core:/usr/share/lmod/lmod/modulefiles/Core
[fgeorgatos@bright-lmod ~]$ module use $HOME/.local/easybuild/modules.all
[fgeorgatos@bright-lmod ~]$ echo $MODULEPATH
/home/fgeorgatos/.local/easybuild/modules.all:/etc/modulefiles:/usr/share/modulefiles:/usr/share/Modules/modulefiles:/usr/share/modulefiles/Linux:/usr/share/modulefiles/Core:/usr/share/lmod/lmod/modulefiles/Core
[fgeorgatos@bright-lmod ~]$ bash
[fgeorgatos@bright-lmod ~]$ echo $MODULEPATH
/etc/modulefiles:/usr/share/modulefiles:/usr/share/Modules/modulefiles
[fgeorgatos@bright-lmod ~]$

btw. the bug is expected to have vanished for most new installs, since the fresher 6.3.1 rollouts:
https://www.rpmfind.net/linux/rpm2html/search.php?query=Lmod

Interestingly, the other bug ml --gitversion does not appear to be fixed.
That has been fixed in this Lmod .spec though: Bright-Computing/bic#13

@boegel
Copy link
Member

boegel commented May 11, 2016

fixed in #1758, let's follow up there?

@boegel boegel closed this as completed May 11, 2016
@boegel boegel added this to the v2.8.0 milestone May 11, 2016
@fgeorgatos
Copy link
Collaborator Author

yeap, nice job there.

btw. I forgot to mention that, also ohpc probably has this issue, as well as any hpc site,
with unguarded blind setting of MODULEPATH to a fixed value. candidate example (as of today):
https://github.com/openhpc/ohpc/blob/master/components/admin/lmod/SPECS/lmod.spec#L111

@boegel
Copy link
Member

boegel commented May 12, 2016

@fgeorgatos Thanks for the feedback, PR going in. Have you reported that to OpenHPC? If not, you should.

@fgeorgatos
Copy link
Collaborator Author

i'm pretty sure I had reported it back then, although I can no longer trace the proof..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants