Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify minimal required setuptools version #31

Closed
wants to merge 4 commits into from

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 4, 2016

No description provided.

@boegel boegel mentioned this pull request Mar 4, 2016
@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

cfr. #16

@hpcugentbot
Copy link

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-install-prbuilder/49/console for more details.

@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

Hmm, this is what we have on SL6 by default...

r-bash-4.1$ rpm -qa | grep setuptools
python-setuptools-0.6.10-3.el6.noarch

-bash-4.1$ python
Python 2.6.6 (r266:84292, Jul 22 2015, 16:47:47) 
[GCC 4.4.7 20120313 (Red Hat 4.4.7-16)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import setuptools
>>> setuptools.__version__
'0.6' 

Thoughts @stdweird?

@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

Even CentOS7 is quite old...

$ python -c "import setuptools; print setuptools.__version__"
0.9.8

@hpcugentbot
Copy link

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-install-prbuilder/50/console for more details.

@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

OK, now also specifying that 0.6 is minimal runtime dep, while 2.0 is a conservative minimal dep for running setup.py (cfr. #16)...

@stdweird
Copy link
Member

building rpms fails, please actually this instead of assuming how it works

INFO: generated scripts list: []
Traceback (most recent call last):
  File "setup.py", line 1366, in <module>
    action_target(PACKAGE)
  File "setup.py", line 1335, in action_target
    setupfn(**x)
  File "/usr/lib64/python2.7/distutils/core.py", line 112, in setup
    _setup_distribution = dist = klass(attrs)
  File "/usr/lib/python2.7/site-packages/setuptools/dist.py", line 265, in __init__
    self.fetch_build_eggs(attrs.pop('setup_requires'))
  File "/usr/lib/python2.7/site-packages/setuptools/dist.py", line 289, in fetch_build_eggs
    parse_requirements(requires), installer=self.fetch_build_egg
  File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 630, in resolve
    raise VersionConflict(dist,req) # XXX put more info here
pkg_resources.VersionConflict: (setuptools 0.9.8 (/usr/lib/python2.7/site-packages), Requirement.parse('setuptools>=2.0'))

@boegel
Copy link
Member Author

boegel commented Mar 10, 2016

@stdweird I didn't make any assumptions, I actually mentioned that the setuptools version on both SL6 and CentOS7 was too old compared to what I have in here...

setuptools 2.0 is only required to run sdist upload without problems (at least on my system), but not for installing or building the RPM, so I guess we can lower the version requirement?

@boegel
Copy link
Member Author

boegel commented Apr 30, 2016

@stdweird ping on my question above?

@JensTimmerman
Copy link
Contributor

yes, better lower it.

@stdweird
Copy link
Member

stdweird commented May 2, 2016

so you are going to lower the version requirement to somethig less than 2.0 yet make it at least 2.0 in order to fix the original issue? can you update the PR so it is clear what you are trying to do and that we can still build rpms?

@boegel
Copy link
Member Author

boegel commented May 2, 2016

@stdweird well, I'm open to suggestions...

For running setup.py bdist_rpm, 0.6 is enough (since we've been building RPMs on SL6 without a problem), for running setup.py sdist upload, it appears 0.6 is not sufficient (2.0 is, there may be a slightly lower version that is also sufficient).

There's no separate version requirement I can specify for sdist upload though, at least not in a clean way...

@hpcugentbot
Copy link

One or more tests FAILed.

See https://jenkins1.ugent.be/job/vsc-install-prbuilder/53/console for more details.

@hpcugentbot
Copy link

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-install-prbuilder/54/console for more details.

@boegel boegel mentioned this pull request May 19, 2016
@boegel
Copy link
Member Author

boegel commented Aug 29, 2016

apparently this turns out to be pretty much useless, so closing

@boegel boegel closed this Aug 29, 2016
@boegel boegel deleted the min_setuptools branch August 29, 2016 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants