add graphyte to send metrics to graphite or carbon #95
Conversation
lib/vsc/utils/netcat.py
Outdated
| """ | ||
| # convert list to string if needed | ||
| if isinstance(data, list): | ||
| data = "\n".join(data) |
There was a problem hiding this comment.
this makes no sense. i would expect either some serialiser, or that it sends element per element
There was a problem hiding this comment.
There was a problem hiding this comment.
valid point on the list, I was only thinking about my use case. I'll remove that.
graphyte is not available on our systems and I don't think maintaining and rpm to replace 2 lines of code is a good idea.
There was a problem hiding this comment.
i'm quite sure the graphyte dev also thought that.
graphyte is 200 lines, and license allows us to include it in vsc-utils if you don't want to build a package for it.
There was a problem hiding this comment.
just to replace the following?
with socket.create_connection((host, port), timeout=timeout) as sock:
sock.sendall(data)
There was a problem hiding this comment.
you are sure we will never need any of the features in graphyte? not so convinced tbh
|
@stdweird this now includes graphyte |
wdpypere
changed the title
not that hard to do, but add some convenience so data can be string or list as well, and some basic logging.