Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/setup e2e tests #19

Merged
merged 17 commits into from
Jan 4, 2022
Merged

Feature/setup e2e tests #19

merged 17 commits into from
Jan 4, 2022

Conversation

Dassderdie
Copy link
Collaborator

@Dassderdie Dassderdie commented Dec 28, 2021 •
edited
Loading

  • Add git LFS for cypress artifacts
  • Add cypress
  • Add vscode tasks & documentation in the README
  • Added visual regression tests via cypress-image-diff
    • The main benefit of the visual regression tests is to use them for everything that is happening on the canvas (map)

All current e2e tests are only examples and should be replaced later on

@Dassderdie Dassderdie marked this pull request as ready for review December 30, 2021 20:50
@Dassderdie Dassderdie added this to In Review in BP2021HG1 Dec 31, 2021
ClFeSc
ClFeSc approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@ClFeSc ClFeSc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I don't know cypress, so I can't say how good or bad its integration is.

.vscode/tasks.json Outdated Show resolved Hide resolved
frontend/cypress/integration/landing-page.spec.ts Show resolved Hide resolved
frontend/cypress/integration/landing-page.spec.ts Outdated Show resolved Hide resolved
frontend/cypress/integration/landing-page.spec.ts Show resolved Hide resolved
frontend/cypress/support/commands.ts Show resolved Hide resolved
ClFeSc
ClFeSc reviewed Jan 3, 2022
View reviewed changes
Copy link
Contributor

@ClFeSc ClFeSc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit the wrong button, there are still some comments.

ClFeSc
ClFeSc requested changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@ClFeSc ClFeSc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@Dassderdie Dassderdie requested a review from ClFeSc January 3, 2022 21:14
@ClFeSc ClFeSc mentioned this pull request Jan 4, 2022
Closed
@Dassderdie Dassderdie removed the request for review from anonym-HPI January 4, 2022 12:50
@Dassderdie Dassderdie merged commit 27de72d into dev Jan 4, 2022
BP2021HG1 automation moved this from In Review to Done Jan 4, 2022
@Dassderdie Dassderdie deleted the feature/setup-e2e-tests branch January 4, 2022 12:50
@Dassderdie Dassderdie mentioned this pull request Jan 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClFeSc ClFeSc ClFeSc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
BP2021HG1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dassderdie @ClFeSc