Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22 Run CI locally #38

Merged
merged 1 commit into from
Jan 9, 2022
Merged

22 Run CI locally #38

merged 1 commit into from
Jan 9, 2022

Conversation

Dassderdie
Copy link
Collaborator

After running the task you can see on the checkmarks that there was no problem:
image

@Dassderdie Dassderdie requested a review from ClFeSc January 8, 2022 17:51
@Dassderdie Dassderdie added the CI This is about the CI label Jan 8, 2022
@Dassderdie Dassderdie added this to In progress in BP2021HG1 via automation Jan 8, 2022
@Dassderdie Dassderdie added this to the 0 milestone Jan 8, 2022
@ClFeSc ClFeSc linked an issue Jan 8, 2022 that may be closed by this pull request
Create task for running the ci locally #22
Closed
ClFeSc
ClFeSc reviewed Jan 8, 2022
View reviewed changes
Copy link
Contributor

@ClFeSc ClFeSc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like this, but I don't think we can get it any better. It works for me, but prettier and cypress fail, prettier complains about a trailing space in README.md line 145 and cypress fails at is possible to make visual regression tests (for e.g. a canvas). Unfortunately, the mentioned screenshots for cypress do not exist. Are these failures expected at this stage?

@Dassderdie
Copy link
Collaborator Author

I don't really like this, but I don't think we can get it any better. It works for me, but prettier and cypress fail, prettier complains about a trailing space in README.md line 145 and cypress fails at is possible to make visual regression tests (for e.g. a canvas). Unfortunately, the mentioned screenshots for cypress do not exist. Are these failures expected at this stage?

The missing space is correct. I think I fixed it on #35.

There should be a frontend\cypress-visual-screenshots\baseline\landing-page.spec.ts-landing page.png

I added git lfs in #19. Could it be that git lfs is not installed on your system? Maybe we should mention it in the README (or remove it and directly add the images to the repo - I just added git lfs because I thought it is a best practice).

@Dassderdie Dassderdie requested a review from ClFeSc January 8, 2022 23:09
ClFeSc
ClFeSc approved these changes Jan 9, 2022
View reviewed changes
Copy link
Contributor

@ClFeSc ClFeSc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed git-lfs. Some thinfs still fail, including linting (and prettier) on files like coverage that are ignored by git but still present locally. But I still think this can be merged as there is probably no point in spending too much time on this when we will have the CI back in two weeks and are all humans able to distinguish a relevant failure from an irrelevant failure of one of the jobs.

@Dassderdie
Copy link
Collaborator Author

About prettier and the linter see #36 ?
I created #40 too

@Dassderdie Dassderdie merged commit 3d1718a into dev Jan 9, 2022
BP2021HG1 automation moved this from In progress to Done Jan 9, 2022
@Dassderdie Dassderdie deleted the feature/22-run-ci-locally branch January 9, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClFeSc ClFeSc ClFeSc approved these changes

Assignees
No one assigned
Labels
CI This is about the CI
Projects
BP2021HG1
  
Done
Milestone
0
Development

Successfully merging this pull request may close these issues.

Create task for running the ci locally
2 participants
@Dassderdie @ClFeSc