Refactor protocol package according to the linter (remaining issues) #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 966
💛 - Coveralls |
timgarrels
approved these changes
Jul 26, 2019
timgarrels
added a commit
that referenced
this pull request
May 1, 2020
* add squeak5-2 CI target and allow trunk to fail * add develop travis batch to readme * Wrap IMAP Credentials into asterixs' for propper IMAP compliance (see RFC 3501 chapter 4.3) * Emphasize LoadOlderMail ist Email list (fixes #168) * Make Endpoint use IMAP conform Strings * Change two hardcoded dictionary keys, which where supposed to be the same * Use theme-defined color for #168 fix * Relocate load-older-emails-button emphasize filter to separate method * Made AuthInfo Object only accept IMAP convertible strings * Added template coverage badge from coveralls * coveralls * added coverage icon * added coverage config to ston * Updated Coverage badge to show develop * Fixed bad double click fix, added good double click api call * $o opens selected Email * Refactored emailListKeyPressMapping * Fix typo * Configure coverage only for Core package * Added install to call Menu Entry Added * update readme * Removed class method and refactored emailListKeyPress: * Renamed and recategorized methods in ICEmail and made one triggle down change in ICFolder because of rename of uid -> uniqueID * Refactor/rename get methods (#198) * Renamed all get* method in Core * Renamed get* methods in UI * Renamed get* methods in Tests * Added lazy init for body and header in ICEmail and removed initialize (#199) * Adde lazy init for body and header in ICEmail and removed initialize * Feature/release building (#206) * Created sar export in test code * Update .travis.yml * Switched from seperate sars to one install sar * Revert "Update .travis.yml" * Feature/searchbar experience (#201) * Change Search Bar Widget from InputText to TextField * set setter and getter so the CR behavior is correct * Implement check for account name existence in login dialog (#205) * Implement check for account name existence in login dialog * Improve semantics of method name * Refactor duplicate finding * Added Lazy init for ICEndPoint, ICFetchResponseParser, ICFolder, ICServerInfo, ICStreamWrapper, ICFolderDialog and ICLoginDialog * Renamed all "anObject" parameters * TDD: Added Tests for Connection Configuration storage in ICEndPoint * Changed a* to an* * Enter confirms password (#220) * Implements #212. Deleted file storage methods in ICHelper and removed their tests. Implemented image storage in ICEndPoint and changed occurences from ICHelper * Tested validity check in ICEndpoint. This was already tested indirectly in the test for addConfiguration. This just removed the indirection. * Split up ICFolderDialog build method * Refactor ICFolderDialog build method * Introduce navigation panel element into ICFolderView * Travis can not handle asDictionary. Therefore changed to Dictionary newFrom: * Moved methods from "as yet unclassified" to fitting categories (#233) * Split build method into multiple methods * Fix empty fields checking and refactor to better naming (#213) * Fix empty fields checking and refactor to better naming * Use higher level collection protocol methods * Removed unused methods (#235) * Removed ICFolder lazy init. Reference to #215 (review) and #215 (comment) * Removed ICLoadOlderMail from Core and added UI-Button which loads older emails * Fix startup configuration (#246) * Add account icon (#247) * Fixed bug which caused account to remove by adding copy (#238) * Fixed bug which caused account to remove by adding copy * Revert hacky fix * Tested occurred bug, added bug fix * Added Class Comments for all classes except the ServiceProvider in th… (#248) * Added Class Comments for all classes except the ServiceProvider in the UI and Test Packages * Ottos Feedback on wording and spelling * Use consistent wording for the description of an instance. * Establish default settings for login dialog (#250) * fixes #223 * Copied parser methods from ICEndPoint to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Refactored the methods that have been relocated to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Add protocol package to smalltalkCI coverage measurement Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Add protocol package to smalltalkCI coverage measurement Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Redirected parse calls in endpoint to parser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Remove parser traces from ICEndPoint Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Fixed small bug caused by typo * Refactor/252 ICAccount info (#254) * Literally just merged ICAuthenticationInfo with ICServerInfo. Had to change constructors of course * Reworked the endpoint login and connection system to work with the new AccountInfo Class. This caused a lot of change in the test code * Fixed renaming issue * Removed unused method * Removed unused method * Renamed ICAccountInfo contructor (legacy artifact) * Review Requests on #254 * Recategorization and little code beautification * name-attribut artifact replacement * Made everything use anAccountINfo instead of Dictionary Made everything use 'accountName' instead of 'name' * Fixed "Account edit" * Fixed Test Defaults * Refactor/218 date formatted test fix (#263) * Added new tests. Made tests more specific * Fixed second and date parsing * Changed private method to travis accessible method * Moved default subject responsibilities (#264) * Moved default subject responsibilities * Code Standard * Refactor/252 ic account info (#266) * Literally just merged ICAuthenticationInfo with ICServerInfo. Had to change constructors of course * Reworked the endpoint login and connection system to work with the new AccountInfo Class. This caused a lot of change in the test code * Fixed renaming issue * Removed unused method * Removed unused method * Renamed ICAccountInfo contructor (legacy artifact) * Review Requests on #254 * Recategorization and little code beautification * name-attribut artifact replacement * Made everything use anAccountINfo instead of Dictionary Made everything use 'accountName' instead of 'name' * Fixed "Account edit" * Fixed Test Defaults * 255 folder name attribute (#262) * Made ICFolder use 'folderName' instead of 'name' * Changed ToolBuilder textfield from 'name' to 'accountName' * Typo fix * Readme/removearchitecture (#267) * remove architecture from readme. it's outdated and visible in the wiki * add hint for people to look at the wiki to readme * Moved Commands from EndPoint to ICCommand (#268) * Added Command Methods to ICCommand * Removed constants from ICCommand because they where dublicate in ICEndPoint Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> * Refactored Methods in ICCommand and methods calls in ICEndPoint Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> * Added class comment (And minor code style refactoring I forgot the last time) * Implemented required Changes * More requested changes Moving constants from EndPoint to Command, renamed Methods and recategorized * Finalize ICParser extraction - fixed broken tests Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Copied ICResponseParser into ICParser * Adapt calls and tests from ICFetchResponseParser to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Law of Demeter, Comment corrected, removed unused method (#270) * "Das kann weg" - Patrick R. (#271) * Requested Changes and removed unused methods Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Remove `ICHelper` (#269) * Removed unused method * Refactor to use collect * Made ICHelpers paramter sort method obsolete * Changed child folder collection * Moved hash function * Moved EndPoint creation out of helper * Removed ICHelper * Pauls Feedback * Moved hash test * Made ICParser compatible with Travis Squeak Build Version Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Fix test that was still using ICHelper Co-authored-by: TIm Garrels <33292335+EatingBacon@users.noreply.github.com> * fix account delete * Create tests for ICNullStream and ICStreamWrapper Co-authored-by: Tim Garrels <33292335+EatingBacon@users.noreply.github.com> * Made ICFolderDialogs `ICEndpoint` usage more obvious (#275) * Made Deployment modular * Fixed whitespace assumption * Added cover for Core Error in UI * Replaced getter with converter * UI Notes origin (#282) * Fixed whitespace assumption * Added cover for Core Error in UI * Switched "UIManager default" usage to usage of "self" * Hotfix for rootfolder and context menu * Fix 'Move to trash' Context Menu * start refactoring to remove linter issues (#286) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * Remove warning at 'Move to trash' (#287) * Refactor the protocol package according to the lint (#290) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * start linting the parser package * First Lint batch (#291) * Second Lint UI Batch (#294) * First Lint batch * Removed comments, replaced checks, shortened methods * Felix' Feedback * Refactor according to Linter in the Test Package (#295) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * Some core linting (#292) * Some core linting * Fix linting mistakes * fix EatingBacon's comments * Refactor all linting issues in Protocol package (#298) * Implemented handling of malicious mime headers (#299) * Made long methodlines short and removes unnecessary comments (#302) * Some core package linting (#301) * Some core package linting * Some more lint refactoring * Remove left over method * Remove some debug code * Fixed lints as far as humanly possible (#305) * Restore Travis Ci links [ci skip] Co-authored-by: Felix Rindt <felix@rindt.me> Co-authored-by: Paul Methfessel <paul.methfessel@web.de> Co-authored-by: Martin Taraz <26792474+martintaraz@users.noreply.github.com> Co-authored-by: Tim Garrels <tim.garrels@student.hpi.de> Co-authored-by: EatingBacon <33292335+EatingBacon@users.noreply.github.com> Co-authored-by: justus.eilers <justus.eilers@student.hpi.de> Co-authored-by: paul.methfessel <paul.methfessel@student.hpi.de> Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> Co-authored-by: Fabio Niephaus <code@fniephaus.com>
timgarrels
added a commit
that referenced
this pull request
May 8, 2020
* add squeak5-2 CI target and allow trunk to fail * add develop travis batch to readme * Wrap IMAP Credentials into asterixs' for propper IMAP compliance (see RFC 3501 chapter 4.3) * Emphasize LoadOlderMail ist Email list (fixes #168) * Make Endpoint use IMAP conform Strings * Change two hardcoded dictionary keys, which where supposed to be the same * Use theme-defined color for #168 fix * Relocate load-older-emails-button emphasize filter to separate method * Made AuthInfo Object only accept IMAP convertible strings * Added template coverage badge from coveralls * coveralls * added coverage icon * added coverage config to ston * Updated Coverage badge to show develop * Fixed bad double click fix, added good double click api call * $o opens selected Email * Refactored emailListKeyPressMapping * Fix typo * Configure coverage only for Core package * Added install to call Menu Entry Added * update readme * Removed class method and refactored emailListKeyPress: * Renamed and recategorized methods in ICEmail and made one triggle down change in ICFolder because of rename of uid -> uniqueID * Refactor/rename get methods (#198) * Renamed all get* method in Core * Renamed get* methods in UI * Renamed get* methods in Tests * Added lazy init for body and header in ICEmail and removed initialize (#199) * Adde lazy init for body and header in ICEmail and removed initialize * Feature/release building (#206) * Created sar export in test code * Update .travis.yml * Switched from seperate sars to one install sar * Revert "Update .travis.yml" * Feature/searchbar experience (#201) * Change Search Bar Widget from InputText to TextField * set setter and getter so the CR behavior is correct * Implement check for account name existence in login dialog (#205) * Implement check for account name existence in login dialog * Improve semantics of method name * Refactor duplicate finding * Added Lazy init for ICEndPoint, ICFetchResponseParser, ICFolder, ICServerInfo, ICStreamWrapper, ICFolderDialog and ICLoginDialog * Renamed all "anObject" parameters * TDD: Added Tests for Connection Configuration storage in ICEndPoint * Changed a* to an* * Enter confirms password (#220) * Implements #212. Deleted file storage methods in ICHelper and removed their tests. Implemented image storage in ICEndPoint and changed occurences from ICHelper * Tested validity check in ICEndpoint. This was already tested indirectly in the test for addConfiguration. This just removed the indirection. * Split up ICFolderDialog build method * Refactor ICFolderDialog build method * Introduce navigation panel element into ICFolderView * Travis can not handle asDictionary. Therefore changed to Dictionary newFrom: * Moved methods from "as yet unclassified" to fitting categories (#233) * Split build method into multiple methods * Fix empty fields checking and refactor to better naming (#213) * Fix empty fields checking and refactor to better naming * Use higher level collection protocol methods * Removed unused methods (#235) * Removed ICFolder lazy init. Reference to #215 (review) and #215 (comment) * Removed ICLoadOlderMail from Core and added UI-Button which loads older emails * Fix startup configuration (#246) * Add account icon (#247) * Fixed bug which caused account to remove by adding copy (#238) * Fixed bug which caused account to remove by adding copy * Revert hacky fix * Tested occurred bug, added bug fix * Added Class Comments for all classes except the ServiceProvider in th… (#248) * Added Class Comments for all classes except the ServiceProvider in the UI and Test Packages * Ottos Feedback on wording and spelling * Use consistent wording for the description of an instance. * Establish default settings for login dialog (#250) * fixes #223 * Copied parser methods from ICEndPoint to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Refactored the methods that have been relocated to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Add protocol package to smalltalkCI coverage measurement Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Add protocol package to smalltalkCI coverage measurement Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Redirected parse calls in endpoint to parser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Remove parser traces from ICEndPoint Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Fixed small bug caused by typo * Refactor/252 ICAccount info (#254) * Literally just merged ICAuthenticationInfo with ICServerInfo. Had to change constructors of course * Reworked the endpoint login and connection system to work with the new AccountInfo Class. This caused a lot of change in the test code * Fixed renaming issue * Removed unused method * Removed unused method * Renamed ICAccountInfo contructor (legacy artifact) * Review Requests on #254 * Recategorization and little code beautification * name-attribut artifact replacement * Made everything use anAccountINfo instead of Dictionary Made everything use 'accountName' instead of 'name' * Fixed "Account edit" * Fixed Test Defaults * Refactor/218 date formatted test fix (#263) * Added new tests. Made tests more specific * Fixed second and date parsing * Changed private method to travis accessible method * Moved default subject responsibilities (#264) * Moved default subject responsibilities * Code Standard * Refactor/252 ic account info (#266) * Literally just merged ICAuthenticationInfo with ICServerInfo. Had to change constructors of course * Reworked the endpoint login and connection system to work with the new AccountInfo Class. This caused a lot of change in the test code * Fixed renaming issue * Removed unused method * Removed unused method * Renamed ICAccountInfo contructor (legacy artifact) * Review Requests on #254 * Recategorization and little code beautification * name-attribut artifact replacement * Made everything use anAccountINfo instead of Dictionary Made everything use 'accountName' instead of 'name' * Fixed "Account edit" * Fixed Test Defaults * 255 folder name attribute (#262) * Made ICFolder use 'folderName' instead of 'name' * Changed ToolBuilder textfield from 'name' to 'accountName' * Typo fix * Readme/removearchitecture (#267) * remove architecture from readme. it's outdated and visible in the wiki * add hint for people to look at the wiki to readme * Moved Commands from EndPoint to ICCommand (#268) * Added Command Methods to ICCommand * Removed constants from ICCommand because they where dublicate in ICEndPoint Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> * Refactored Methods in ICCommand and methods calls in ICEndPoint Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> * Added class comment (And minor code style refactoring I forgot the last time) * Implemented required Changes * More requested changes Moving constants from EndPoint to Command, renamed Methods and recategorized * Finalize ICParser extraction - fixed broken tests Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Copied ICResponseParser into ICParser * Adapt calls and tests from ICFetchResponseParser to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Law of Demeter, Comment corrected, removed unused method (#270) * "Das kann weg" - Patrick R. (#271) * Requested Changes and removed unused methods Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Remove `ICHelper` (#269) * Removed unused method * Refactor to use collect * Made ICHelpers paramter sort method obsolete * Changed child folder collection * Moved hash function * Moved EndPoint creation out of helper * Removed ICHelper * Pauls Feedback * Moved hash test * Made ICParser compatible with Travis Squeak Build Version Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Fix test that was still using ICHelper Co-authored-by: TIm Garrels <33292335+EatingBacon@users.noreply.github.com> * fix account delete * Create tests for ICNullStream and ICStreamWrapper Co-authored-by: Tim Garrels <33292335+EatingBacon@users.noreply.github.com> * Made ICFolderDialogs `ICEndpoint` usage more obvious (#275) * Made Deployment modular * Fixed whitespace assumption * Added cover for Core Error in UI * Replaced getter with converter * UI Notes origin (#282) * Fixed whitespace assumption * Added cover for Core Error in UI * Switched "UIManager default" usage to usage of "self" * Hotfix for rootfolder and context menu * Fix 'Move to trash' Context Menu * start refactoring to remove linter issues (#286) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * Remove warning at 'Move to trash' (#287) * Refactor the protocol package according to the lint (#290) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * start linting the parser package * First Lint batch (#291) * Second Lint UI Batch (#294) * First Lint batch * Removed comments, replaced checks, shortened methods * Felix' Feedback * Refactor according to Linter in the Test Package (#295) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * Some core linting (#292) * Some core linting * Fix linting mistakes * fix EatingBacon's comments * Refactor all linting issues in Protocol package (#298) * Implemented handling of malicious mime headers (#299) * Made long methodlines short and removes unnecessary comments (#302) * Some core package linting (#301) * Some core package linting * Some more lint refactoring * Remove left over method * Remove some debug code * Fixed lints as far as humanly possible (#305) * Restore Travis Ci links [ci skip] Co-authored-by: Felix Rindt <felix@rindt.me> Co-authored-by: Paul Methfessel <paul.methfessel@web.de> Co-authored-by: Martin Taraz <26792474+martintaraz@users.noreply.github.com> Co-authored-by: Tim Garrels <tim.garrels@student.hpi.de> Co-authored-by: EatingBacon <33292335+EatingBacon@users.noreply.github.com> Co-authored-by: justus.eilers <justus.eilers@student.hpi.de> Co-authored-by: paul.methfessel <paul.methfessel@student.hpi.de> Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> Co-authored-by: Fabio Niephaus <code@fniephaus.com> Co-authored-by: Otto K <1622854+EightSQ@users.noreply.github.com> Co-authored-by: Felix Rindt <felix@rindt.me> Co-authored-by: Paul Methfessel <paul.methfessel@web.de> Co-authored-by: Martin Taraz <26792474+martintaraz@users.noreply.github.com> Co-authored-by: justus.eilers <justus.eilers@student.hpi.de> Co-authored-by: paul.methfessel <paul.methfessel@student.hpi.de> Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> Co-authored-by: Fabio Niephaus <code@fniephaus.com>
timgarrels
added a commit
that referenced
this pull request
May 8, 2020
* add squeak5-2 CI target and allow trunk to fail * add develop travis batch to readme * Wrap IMAP Credentials into asterixs' for propper IMAP compliance (see RFC 3501 chapter 4.3) * Emphasize LoadOlderMail ist Email list (fixes #168) * Make Endpoint use IMAP conform Strings * Change two hardcoded dictionary keys, which where supposed to be the same * Use theme-defined color for #168 fix * Relocate load-older-emails-button emphasize filter to separate method * Made AuthInfo Object only accept IMAP convertible strings * Added template coverage badge from coveralls * coveralls * added coverage icon * added coverage config to ston * Updated Coverage badge to show develop * Fixed bad double click fix, added good double click api call * $o opens selected Email * Refactored emailListKeyPressMapping * Fix typo * Configure coverage only for Core package * Added install to call Menu Entry Added * update readme * Removed class method and refactored emailListKeyPress: * Renamed and recategorized methods in ICEmail and made one triggle down change in ICFolder because of rename of uid -> uniqueID * Refactor/rename get methods (#198) * Renamed all get* method in Core * Renamed get* methods in UI * Renamed get* methods in Tests * Added lazy init for body and header in ICEmail and removed initialize (#199) * Adde lazy init for body and header in ICEmail and removed initialize * Feature/release building (#206) * Created sar export in test code * Update .travis.yml * Switched from seperate sars to one install sar * Revert "Update .travis.yml" * Feature/searchbar experience (#201) * Change Search Bar Widget from InputText to TextField * set setter and getter so the CR behavior is correct * Implement check for account name existence in login dialog (#205) * Implement check for account name existence in login dialog * Improve semantics of method name * Refactor duplicate finding * Added Lazy init for ICEndPoint, ICFetchResponseParser, ICFolder, ICServerInfo, ICStreamWrapper, ICFolderDialog and ICLoginDialog * Renamed all "anObject" parameters * TDD: Added Tests for Connection Configuration storage in ICEndPoint * Changed a* to an* * Enter confirms password (#220) * Implements #212. Deleted file storage methods in ICHelper and removed their tests. Implemented image storage in ICEndPoint and changed occurences from ICHelper * Tested validity check in ICEndpoint. This was already tested indirectly in the test for addConfiguration. This just removed the indirection. * Split up ICFolderDialog build method * Refactor ICFolderDialog build method * Introduce navigation panel element into ICFolderView * Travis can not handle asDictionary. Therefore changed to Dictionary newFrom: * Moved methods from "as yet unclassified" to fitting categories (#233) * Split build method into multiple methods * Fix empty fields checking and refactor to better naming (#213) * Fix empty fields checking and refactor to better naming * Use higher level collection protocol methods * Removed unused methods (#235) * Removed ICFolder lazy init. Reference to #215 (review) and #215 (comment) * Removed ICLoadOlderMail from Core and added UI-Button which loads older emails * Fix startup configuration (#246) * Add account icon (#247) * Fixed bug which caused account to remove by adding copy (#238) * Fixed bug which caused account to remove by adding copy * Revert hacky fix * Tested occurred bug, added bug fix * Added Class Comments for all classes except the ServiceProvider in th… (#248) * Added Class Comments for all classes except the ServiceProvider in the UI and Test Packages * Ottos Feedback on wording and spelling * Use consistent wording for the description of an instance. * Establish default settings for login dialog (#250) * fixes #223 * Copied parser methods from ICEndPoint to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Refactored the methods that have been relocated to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Add protocol package to smalltalkCI coverage measurement Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Add protocol package to smalltalkCI coverage measurement Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Redirected parse calls in endpoint to parser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Remove parser traces from ICEndPoint Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Fixed small bug caused by typo * Refactor/252 ICAccount info (#254) * Literally just merged ICAuthenticationInfo with ICServerInfo. Had to change constructors of course * Reworked the endpoint login and connection system to work with the new AccountInfo Class. This caused a lot of change in the test code * Fixed renaming issue * Removed unused method * Removed unused method * Renamed ICAccountInfo contructor (legacy artifact) * Review Requests on #254 * Recategorization and little code beautification * name-attribut artifact replacement * Made everything use anAccountINfo instead of Dictionary Made everything use 'accountName' instead of 'name' * Fixed "Account edit" * Fixed Test Defaults * Refactor/218 date formatted test fix (#263) * Added new tests. Made tests more specific * Fixed second and date parsing * Changed private method to travis accessible method * Moved default subject responsibilities (#264) * Moved default subject responsibilities * Code Standard * Refactor/252 ic account info (#266) * Literally just merged ICAuthenticationInfo with ICServerInfo. Had to change constructors of course * Reworked the endpoint login and connection system to work with the new AccountInfo Class. This caused a lot of change in the test code * Fixed renaming issue * Removed unused method * Removed unused method * Renamed ICAccountInfo contructor (legacy artifact) * Review Requests on #254 * Recategorization and little code beautification * name-attribut artifact replacement * Made everything use anAccountINfo instead of Dictionary Made everything use 'accountName' instead of 'name' * Fixed "Account edit" * Fixed Test Defaults * 255 folder name attribute (#262) * Made ICFolder use 'folderName' instead of 'name' * Changed ToolBuilder textfield from 'name' to 'accountName' * Typo fix * Readme/removearchitecture (#267) * remove architecture from readme. it's outdated and visible in the wiki * add hint for people to look at the wiki to readme * Moved Commands from EndPoint to ICCommand (#268) * Added Command Methods to ICCommand * Removed constants from ICCommand because they where dublicate in ICEndPoint Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> * Refactored Methods in ICCommand and methods calls in ICEndPoint Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> * Added class comment (And minor code style refactoring I forgot the last time) * Implemented required Changes * More requested changes Moving constants from EndPoint to Command, renamed Methods and recategorized * Finalize ICParser extraction - fixed broken tests Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Copied ICResponseParser into ICParser * Adapt calls and tests from ICFetchResponseParser to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Law of Demeter, Comment corrected, removed unused method (#270) * "Das kann weg" - Patrick R. (#271) * Requested Changes and removed unused methods Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Remove `ICHelper` (#269) * Removed unused method * Refactor to use collect * Made ICHelpers paramter sort method obsolete * Changed child folder collection * Moved hash function * Moved EndPoint creation out of helper * Removed ICHelper * Pauls Feedback * Moved hash test * Made ICParser compatible with Travis Squeak Build Version Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Fix test that was still using ICHelper Co-authored-by: TIm Garrels <33292335+EatingBacon@users.noreply.github.com> * fix account delete * Create tests for ICNullStream and ICStreamWrapper Co-authored-by: Tim Garrels <33292335+EatingBacon@users.noreply.github.com> * Made ICFolderDialogs `ICEndpoint` usage more obvious (#275) * Made Deployment modular * Fixed whitespace assumption * Added cover for Core Error in UI * Replaced getter with converter * UI Notes origin (#282) * Fixed whitespace assumption * Added cover for Core Error in UI * Switched "UIManager default" usage to usage of "self" * Hotfix for rootfolder and context menu * Fix 'Move to trash' Context Menu * start refactoring to remove linter issues (#286) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * Remove warning at 'Move to trash' (#287) * Refactor the protocol package according to the lint (#290) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * start linting the parser package * First Lint batch (#291) * Second Lint UI Batch (#294) * First Lint batch * Removed comments, replaced checks, shortened methods * Felix' Feedback * Refactor according to Linter in the Test Package (#295) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * Some core linting (#292) * Some core linting * Fix linting mistakes * fix EatingBacon's comments * Refactor all linting issues in Protocol package (#298) * Implemented handling of malicious mime headers (#299) * Made long methodlines short and removes unnecessary comments (#302) * Some core package linting (#301) * Some core package linting * Some more lint refactoring * Remove left over method * Remove some debug code * Fixed lints as far as humanly possible (#305) * Restore Travis Ci links [ci skip] Co-authored-by: Felix Rindt <felix@rindt.me> Co-authored-by: Paul Methfessel <paul.methfessel@web.de> Co-authored-by: Martin Taraz <26792474+martintaraz@users.noreply.github.com> Co-authored-by: Tim Garrels <tim.garrels@student.hpi.de> Co-authored-by: EatingBacon <33292335+EatingBacon@users.noreply.github.com> Co-authored-by: justus.eilers <justus.eilers@student.hpi.de> Co-authored-by: paul.methfessel <paul.methfessel@student.hpi.de> Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> Co-authored-by: Fabio Niephaus <code@fniephaus.com> Co-authored-by: Otto K <1622854+EightSQ@users.noreply.github.com> Co-authored-by: Felix Rindt <felix@rindt.me> Co-authored-by: Paul Methfessel <paul.methfessel@web.de> Co-authored-by: Martin Taraz <26792474+martintaraz@users.noreply.github.com> Co-authored-by: justus.eilers <justus.eilers@student.hpi.de> Co-authored-by: paul.methfessel <paul.methfessel@student.hpi.de> Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> Co-authored-by: Fabio Niephaus <code@fniephaus.com>
timgarrels
added a commit
that referenced
this pull request
May 8, 2020
* add squeak5-2 CI target and allow trunk to fail * add develop travis batch to readme * Wrap IMAP Credentials into asterixs' for propper IMAP compliance (see RFC 3501 chapter 4.3) * Emphasize LoadOlderMail ist Email list (fixes #168) * Make Endpoint use IMAP conform Strings * Change two hardcoded dictionary keys, which where supposed to be the same * Use theme-defined color for #168 fix * Relocate load-older-emails-button emphasize filter to separate method * Made AuthInfo Object only accept IMAP convertible strings * Added template coverage badge from coveralls * coveralls * added coverage icon * added coverage config to ston * Updated Coverage badge to show develop * Fixed bad double click fix, added good double click api call * $o opens selected Email * Refactored emailListKeyPressMapping * Fix typo * Configure coverage only for Core package * Added install to call Menu Entry Added * update readme * Removed class method and refactored emailListKeyPress: * Renamed and recategorized methods in ICEmail and made one triggle down change in ICFolder because of rename of uid -> uniqueID * Refactor/rename get methods (#198) * Renamed all get* method in Core * Renamed get* methods in UI * Renamed get* methods in Tests * Added lazy init for body and header in ICEmail and removed initialize (#199) * Adde lazy init for body and header in ICEmail and removed initialize * Feature/release building (#206) * Created sar export in test code * Update .travis.yml * Switched from seperate sars to one install sar * Revert "Update .travis.yml" * Feature/searchbar experience (#201) * Change Search Bar Widget from InputText to TextField * set setter and getter so the CR behavior is correct * Implement check for account name existence in login dialog (#205) * Implement check for account name existence in login dialog * Improve semantics of method name * Refactor duplicate finding * Added Lazy init for ICEndPoint, ICFetchResponseParser, ICFolder, ICServerInfo, ICStreamWrapper, ICFolderDialog and ICLoginDialog * Renamed all "anObject" parameters * TDD: Added Tests for Connection Configuration storage in ICEndPoint * Changed a* to an* * Enter confirms password (#220) * Implements #212. Deleted file storage methods in ICHelper and removed their tests. Implemented image storage in ICEndPoint and changed occurences from ICHelper * Tested validity check in ICEndpoint. This was already tested indirectly in the test for addConfiguration. This just removed the indirection. * Split up ICFolderDialog build method * Refactor ICFolderDialog build method * Introduce navigation panel element into ICFolderView * Travis can not handle asDictionary. Therefore changed to Dictionary newFrom: * Moved methods from "as yet unclassified" to fitting categories (#233) * Split build method into multiple methods * Fix empty fields checking and refactor to better naming (#213) * Fix empty fields checking and refactor to better naming * Use higher level collection protocol methods * Removed unused methods (#235) * Removed ICFolder lazy init. Reference to #215 (review) and #215 (comment) * Removed ICLoadOlderMail from Core and added UI-Button which loads older emails * Fix startup configuration (#246) * Add account icon (#247) * Fixed bug which caused account to remove by adding copy (#238) * Fixed bug which caused account to remove by adding copy * Revert hacky fix * Tested occurred bug, added bug fix * Added Class Comments for all classes except the ServiceProvider in th… (#248) * Added Class Comments for all classes except the ServiceProvider in the UI and Test Packages * Ottos Feedback on wording and spelling * Use consistent wording for the description of an instance. * Establish default settings for login dialog (#250) * fixes #223 * Copied parser methods from ICEndPoint to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Refactored the methods that have been relocated to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Add protocol package to smalltalkCI coverage measurement Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Add protocol package to smalltalkCI coverage measurement Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Redirected parse calls in endpoint to parser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Remove parser traces from ICEndPoint Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Fixed small bug caused by typo * Refactor/252 ICAccount info (#254) * Literally just merged ICAuthenticationInfo with ICServerInfo. Had to change constructors of course * Reworked the endpoint login and connection system to work with the new AccountInfo Class. This caused a lot of change in the test code * Fixed renaming issue * Removed unused method * Removed unused method * Renamed ICAccountInfo contructor (legacy artifact) * Review Requests on #254 * Recategorization and little code beautification * name-attribut artifact replacement * Made everything use anAccountINfo instead of Dictionary Made everything use 'accountName' instead of 'name' * Fixed "Account edit" * Fixed Test Defaults * Refactor/218 date formatted test fix (#263) * Added new tests. Made tests more specific * Fixed second and date parsing * Changed private method to travis accessible method * Moved default subject responsibilities (#264) * Moved default subject responsibilities * Code Standard * Refactor/252 ic account info (#266) * Literally just merged ICAuthenticationInfo with ICServerInfo. Had to change constructors of course * Reworked the endpoint login and connection system to work with the new AccountInfo Class. This caused a lot of change in the test code * Fixed renaming issue * Removed unused method * Removed unused method * Renamed ICAccountInfo contructor (legacy artifact) * Review Requests on #254 * Recategorization and little code beautification * name-attribut artifact replacement * Made everything use anAccountINfo instead of Dictionary Made everything use 'accountName' instead of 'name' * Fixed "Account edit" * Fixed Test Defaults * 255 folder name attribute (#262) * Made ICFolder use 'folderName' instead of 'name' * Changed ToolBuilder textfield from 'name' to 'accountName' * Typo fix * Readme/removearchitecture (#267) * remove architecture from readme. it's outdated and visible in the wiki * add hint for people to look at the wiki to readme * Moved Commands from EndPoint to ICCommand (#268) * Added Command Methods to ICCommand * Removed constants from ICCommand because they where dublicate in ICEndPoint Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> * Refactored Methods in ICCommand and methods calls in ICEndPoint Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> * Added class comment (And minor code style refactoring I forgot the last time) * Implemented required Changes * More requested changes Moving constants from EndPoint to Command, renamed Methods and recategorized * Finalize ICParser extraction - fixed broken tests Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Copied ICResponseParser into ICParser * Adapt calls and tests from ICFetchResponseParser to ICParser Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Law of Demeter, Comment corrected, removed unused method (#270) * "Das kann weg" - Patrick R. (#271) * Requested Changes and removed unused methods Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Remove `ICHelper` (#269) * Removed unused method * Refactor to use collect * Made ICHelpers paramter sort method obsolete * Changed child folder collection * Moved hash function * Moved EndPoint creation out of helper * Removed ICHelper * Pauls Feedback * Moved hash test * Made ICParser compatible with Travis Squeak Build Version Co-authored-by: Otto Kissig <1622854+EightSQ@users.noreply.github.com> * Fix test that was still using ICHelper Co-authored-by: TIm Garrels <33292335+EatingBacon@users.noreply.github.com> * fix account delete * Create tests for ICNullStream and ICStreamWrapper Co-authored-by: Tim Garrels <33292335+EatingBacon@users.noreply.github.com> * Made ICFolderDialogs `ICEndpoint` usage more obvious (#275) * Made Deployment modular * Fixed whitespace assumption * Added cover for Core Error in UI * Replaced getter with converter * UI Notes origin (#282) * Fixed whitespace assumption * Added cover for Core Error in UI * Switched "UIManager default" usage to usage of "self" * Hotfix for rootfolder and context menu * Fix 'Move to trash' Context Menu * start refactoring to remove linter issues (#286) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * Remove warning at 'Move to trash' (#287) * Refactor the protocol package according to the lint (#290) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * start linting the parser package * First Lint batch (#291) * Second Lint UI Batch (#294) * First Lint batch * Removed comments, replaced checks, shortened methods * Felix' Feedback * Refactor according to Linter in the Test Package (#295) * start refactoring to remove linter issues * fix issues according to the review from @EightSQ * Some core linting (#292) * Some core linting * Fix linting mistakes * fix EatingBacon's comments * Refactor all linting issues in Protocol package (#298) * Implemented handling of malicious mime headers (#299) * Made long methodlines short and removes unnecessary comments (#302) * Some core package linting (#301) * Some core package linting * Some more lint refactoring * Remove left over method * Remove some debug code * Fixed lints as far as humanly possible (#305) * Restore Travis Ci links [ci skip] Co-authored-by: Felix Rindt <felix@rindt.me> Co-authored-by: Paul Methfessel <paul.methfessel@web.de> Co-authored-by: Martin Taraz <26792474+martintaraz@users.noreply.github.com> Co-authored-by: Tim Garrels <tim.garrels@student.hpi.de> Co-authored-by: EatingBacon <33292335+EatingBacon@users.noreply.github.com> Co-authored-by: justus.eilers <justus.eilers@student.hpi.de> Co-authored-by: paul.methfessel <paul.methfessel@student.hpi.de> Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> Co-authored-by: Fabio Niephaus <code@fniephaus.com> Co-authored-by: Otto K <1622854+EightSQ@users.noreply.github.com> Co-authored-by: Felix Rindt <felix@rindt.me> Co-authored-by: Paul Methfessel <paul.methfessel@web.de> Co-authored-by: Martin Taraz <26792474+martintaraz@users.noreply.github.com> Co-authored-by: justus.eilers <justus.eilers@student.hpi.de> Co-authored-by: paul.methfessel <paul.methfessel@student.hpi.de> Co-authored-by: Felix Rindt <felix.rindt@student.hpi.de> Co-authored-by: Fabio Niephaus <code@fniephaus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.