Refactor textstructure #118
Conversation
packages/RichTextEditing-Core.package/ExtendableText.class/instance/mayBeExtended.st
Outdated
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/RichTextDocument.class/instance/getTextStructure..st
Outdated
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/RichTextDocument.class/instance/initializeStructure..st
Outdated
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/RichTextDocument.class/instance/removeStructure..st
Outdated
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/RichTextStructureEditor.class/instance/getAttributeAt..st
Outdated
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/RichTextStructureEditor.class/instance/removeColor.st
Outdated
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/TextStructure.class/instance/amount.st
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/TextStructure.class/instance/attributes..st
Outdated
Show resolved
Hide resolved
...s/RichTextEditing-Core.package/TextStructure.class/instance/couldDeriveFromPrettyPrinting.st
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/TextStructure.class/instance/isKern.st
Show resolved
Hide resolved
|
Extendable attributes should be improved on, currently there is only an option to disable extendability. |
|
I would approve merge when Travis build is successfull and Coveage is at least 90.5% (still resulting in a drop of 1%). This does not have to be done by @konradh of course. |
There was a problem hiding this comment.
Generally speaking I like the new design, as it allows for more flexibility when creating new sorts of text structures.
I‘m unsure about the fact, that a TextStructure could hold multiple color/font etc. attributes as this is kinda counterintuitive and imo does not make sense at all. Furthermore this might be prone to issues when evaluating which style will be applied.
I was just wondering, what happens if a user creates a new attribute with the same symbol as our predefined ones. I think this will lead to errors and should be checked when creating a new structure by our user.
packages/RichTextEditing-Core.package/RichTextDocument.class/class/defaultStyles.st
Outdated
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/RichTextDocument.class/class/initialURLStructure.st
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/RichTextDocument.class/instance/textStructureAt..st
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/RichTextEditor.class/instance/makeTextURLFrom..st
Show resolved
Hide resolved
packages/RichTextEditing-Core.package/RichTextStructureEditor.class/class/allAttributes.st
Outdated
Show resolved
Hide resolved
...xtEditing-Core.package/RichTextStructureEditor.class/instance/setColorOfCurrentStructure..st
Outdated
Show resolved
Hide resolved
...extEditing-Core.package/RichTextStructureEditor.class/instance/setFontOfCurrentStructure..st
Outdated
Show resolved
Hide resolved
....package/RichTextTextStructureTests.class/instance/testNullTextStructureCantAddAttributes.st
Outdated
Show resolved
Hide resolved
...ckage/RichTextTextStructureTests.class/instance/testNullTextStructureCantRemoveAttributes.st
Outdated
Show resolved
Hide resolved
.../RichTextEditing-Core.package/RichTextStructureEditor.class/instance/isActiveAttributeAt..st
Outdated
Show resolved
Hide resolved
|
(Review 1h just reading through all changes lol) |
packages/RichTextEditing-Core.package/TextExtendability.class/README.md
Outdated
Show resolved
Hide resolved
|
What is stopping us from merging this? The coverage? |
|
I think this can be merged now. |
No description provided.