-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto completion can be toggled on and off #127
Conversation
I assume there is no way to test this? |
@sirkrypt0 Maybe you could try to type and then check number of morphs / number of text suggestion morphs while typing? |
If you want to test the Autocompletion, make sure it's installed first. The API of the Autocompletion is mostly not guaranteed, but it still doesn't change very often. You can access the Autocompletions controller using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure why this is necessary as RichTextEditorModel>>#initializeCompletionController
is now exactly the same as Model>>#initializeCompletionController
, which we inherit anyway.
It should make absolutely no difference.
Enabling and disabling autocompletion already worked for me before.
It doesn't seem to work for anyone else usually, but on this branch it does work for me |
I think we should do that to really make sure it can be toggled off and on reliably. |
I agree, it works here |
utilities | ||
enableAutocompletion | ||
|
||
autocompletionPreference := RichTextEditorModel autocompletion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no accessors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we did settle on always using them
...extEditing-Core.package/RichTextEditorModel.class/instance/initializeCompletionController.st
Outdated
Show resolved
Hide resolved
...ges/RichTextEditing-Tests.package/RichTextEditorTests.class/instance/enableAutocompletion.st
Outdated
Show resolved
Hide resolved
…ss/instance/enableAutocompletion.st Co-authored-by: sirkrypt0 <22522058+sirkrypt0@users.noreply.github.com>
todo: Test should really test for autocompletion (acceptance test) |
maybe consider adding these changes on a new branch to avoid merge conflicts |
Should fix #60