auto completion can be toggled on and off

[frcroth]

Should fix #60

[sirkrypt0]

I assume there is no way to test this?

[frcroth]

I assume there is no way to test this?

@sirkrypt0 Maybe you could try to type and then check number of morphs / number of text suggestion morphs while typing?

[LeonMatthes]

If you want to test the Autocompletion, make sure it's installed first.
You can add it as a dependency of your test package in your Baseline (repo is here ).

The API of the Autocompletion is mostly not guaranteed, but it still doesn't change very often.

You can access the Autocompletions controller using Model>>#completionController and then use ECController>>#isMenuOpen to check whether the autocompletion is opened.

[konradh]

I'm not really sure why this is necessary as RichTextEditorModel>>#initializeCompletionController is now exactly the same as Model>>#initializeCompletionController, which we inherit anyway.
It should make absolutely no difference.
Enabling and disabling autocompletion already worked for me before.

[frcroth]

I'm not really sure why this is necessary as RichTextEditorModel>>#initializeCompletionController is now exactly the same as Model>>#initializeCompletionController, which we inherit anyway.
It should make absolutely no difference.
Enabling and disabling autocompletion already worked for me before.

It doesn't seem to work for anyone else usually, but on this branch it does work for me

[sirkrypt0]

If you want to test the Autocompletion, make sure it's installed first.
You can add it as a dependency of your test package in your Baseline (repo is here ).

The API of the Autocompletion is mostly not guaranteed, but it still doesn't change very often.

You can access the Autocompletions controller using Model>>#completionController and then use ECController>>#isMenuOpen to check whether the autocompletion is opened.

I think we should do that to really make sure it can be toggled off and on reliably.

[sirkrypt0]

I'm not really sure why this is necessary as RichTextEditorModel>>#initializeCompletionController is now exactly the same as Model>>#initializeCompletionController, which we inherit anyway.
It should make absolutely no difference.
Enabling and disabling autocompletion already worked for me before.

It doesn't seem to work for anyone else usually, but on this branch it does work for me

I agree, it works here

[j-hellenberg]

Why no accessors?

[frcroth]

not necessary

[j-hellenberg]

I thought we did settle on always using them

[frcroth]

todo: Test should really test for autocompletion (acceptance test)

[sirkrypt0]

maybe consider adding these changes on a new branch to avoid merge conflicts