Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keymap preference #178

Merged
merged 8 commits into from
Aug 7, 2020
Merged

Add keymap preference #178

merged 8 commits into from
Aug 7, 2020

Conversation

sirkrypt0
Copy link
Contributor

@sirkrypt0 sirkrypt0 commented Aug 6, 2020 •
edited
Loading

Closes #183

@sirkrypt0 sirkrypt0 mentioned this pull request Aug 6, 2020
Merged
@frcroth
Copy link
Contributor

frcroth commented Aug 6, 2020

Can be merged IMO

@sirkrypt0
Copy link
Contributor Author

should have tests

@frcroth
Copy link
Contributor

frcroth commented Aug 7, 2020

should have tests

Are you working on this?

@sirkrypt0 sirkrypt0 marked this pull request as ready for review August 7, 2020 09:27
frcroth
frcroth requested changes Aug 7, 2020
View reviewed changes
packages/RichTextEditing-Tests.package/RichTextEditorTests.class/instance/setUp.st Outdated
@@ -0,0 +1,5 @@
resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to running

...ichTextEditing-Tests.package/RichTextEditorTests.class/instance/structureKeymapPreference.st
constants
structureKeymapPreference

^ (self textEditor class asString , '>>', 'structureKeymap') asSymbol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's that?

packages/RichTextEditing-Tests.package/RichTextEditorTests.class/instance/tearDown.st Outdated
@@ -0,0 +1,5 @@
resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running

@frcroth frcroth merged commit c743cb6 into dev Aug 7, 2020
@frcroth frcroth deleted the feature/keymap-preference branch August 7, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frcroth frcroth frcroth approved these changes

@oleschl oleschl oleschl approved these changes

@j-hellenberg j-hellenberg Awaiting requested review from j-hellenberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add preference for keymap
3 participants
@sirkrypt0 @frcroth @oleschl